Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3154

meas_astrom still using eups in tests

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom, pipe_tasks
    • Labels:
      None
    • Story Points:
      2
    • Team:
      Architecture

      Description

      In DM-2636 we modified the tests to be skipped if EUPS is not available. I've had a closer look and all the ones I have glanced at seem to be easily fixable to run without EUPS. The tests seem to be using EUPS to locate the meas_astrom (effectively asking EUPS for the location of the test file), then a path to the astrometry.net test data within the tests/ directory is located and then EUPS is asked to setup astrometry_net_data using that path. Since the table files are all empty this is the equivalent to simply assigning the ASTROMETRY_NET_DATA_DIR environment variable directly to the path in the tests sub-directory.

      Making this change to one of the tests seems to work so I will change the rest.

        Attachments

          Issue Links

            Activity

            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-2636 [ DM-2636 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to RFC-44 [ RFC-44 ]
            tjenness Tim Jenness made changes -
            Link This issue is blocked by DM-3142 [ DM-3142 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to SIM-1264 [ SIM-1264 ]
            price Paul Price made changes -
            Status To Do [ 10001 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Reviewers Paul Price [ price ]
            Status Reviewed [ 10101 ] In Review [ 10004 ]
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Status Reviewed [ 10101 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Component/s pipe_tasks [ 10726 ]
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Team SQuaRE [ 10302 ] Architecture [ 10304 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Paul Price
              Watchers:
              Joshua Hoblitt, Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.