Looks like this was put in by Perry on DM-980. Might want to ping him on
this as well.
Andy

On Thu, Jul 16, 2015 at 4:16 PM, John Swinbank (JIRA) <jira-dm@lsst.org>

Thanks; I suspect this just got garbled in the transition to the meas_base framework, but Perry Gee please do chime in if you have anything to add!

After a few minutes of poking about, I decided we do want to keep this method, but fix it up so it actually works properly and then make use of it. Fix is just a few lines.

Ok, looks like tickets/DM-3159 on ip_diffim does the trick. Perry Gee, could I trouble you for a quick review please?

The changes look OK. However, at least on my machine, a few of the unit tests are failing. Do these pass on buildBot? If so, I won't worry about it. They are specific failures, unrelated to the change in this ticket.

BTW, I did not get this stream of questions in my email, or perhaps it is being spam filtered. I apologize for not responding.

As far as the "return" is concerned, my recollection is that at the time, the setDefaults was not working correctly, though I only have a vague recollection of it. I don't think there was a super class setDefault() call in the original code, and perhaps there should have been. I was therefore forced to put these settings in other places to get the unit tests to pass.

I checked it in in this weird state because Simon thought that the code needed rework, and that someone would be assigned to work on it when he got some new hires and could figure out the problems. I should have commented why the return was there at the time.

Changes look fine, with the proviso that some of the unit tests are failing. See my previous comment.

Thanks Perry Gee. I'm a bit worried about the failing tests, though. Since they work for me and for CI I think everything is fine, but perhaps you could provide bit more detail about what the problem is?

Sorry to hear about your e-mail difficulties! It's always a tiresome when something like that breaks. However, we really do rely on people being responsive to JIRA in order to get things done. If the problem recurs, please do take time to track it down and make sure it's fixed – you'll find that Frossie Economou and the rest of the SQuaRE team can help with JIRA problems, but you'll need to take care of your own spam filters!

I am going to do a complete new release, and assuming it builds, I will try
again. May be that something is out of date.

I do think there is something wrong with my email notifications, so I am
going to try to learn more about it and see if I can figure it out.

On Thu, Jul 30, 2015 at 3:32 PM, John Swinbank (JIRA) <jira-dm@lsst.org>

META: Will the person who made the 2nd and 9th comment in this ticket please identify themselves to me (off-ticket) so we can figure out why JIRA is confused about your identity.

I made one of these comments. I think that this is an old problem which I
thought we had fixed. It has to do with my email address not being known.
I am using pgee2000@gmail.com,t but it is possible that I am listed as
pgee@physics.ucdavis.edu in some places.

On Thu, Jul 30, 2015 at 11:50 PM, Frossie Economou (JIRA) <jira-dm@lsst.org>

Perry Gee – any progress on this? It would be nice to close it before the end of this sprint/cycle.

My intention was to OK this for checkup, subject to any unit tests which might be failing on buildBot. I have reviewed the code.