Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3160

Improve name and default value of MeasureApCorrConfig.refFluxAlg

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      The config name refFluxAlg should be refFluxField (since it is a flux field name prefix) and the default should be base_CircularApertureFlux_5 instead of base_CircularApertureFlux_0 (thus giving a reasonable radius instead of one that is ridiculously too small).

      I should have handled it on DM-436 but it slipped through.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Jim: could you please take a quick look? This is a nearly trivial change on meas_base tickets/DM-3160 to measureApCorr.py. I renamed one config field (and that field is only used in one place) and changed the default from base_CircularApertureFlux_0 to base_CircularApertureFlux_5. This gives sane results with Dominique Boutigny's CFHT demo, as shows in my last comment in DM-436.

            Show
            rowen Russell Owen added a comment - Jim: could you please take a quick look? This is a nearly trivial change on meas_base tickets/ DM-3160 to measureApCorr.py. I renamed one config field (and that field is only used in one place) and changed the default from base_CircularApertureFlux_0 to base_CircularApertureFlux_5. This gives sane results with Dominique Boutigny's CFHT demo, as shows in my last comment in DM-436 .
            Hide
            jbosch Jim Bosch added a comment -

            Looks fine.

            Show
            jbosch Jim Bosch added a comment - Looks fine.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick review. Merged to master.

            Show
            rowen Russell Owen added a comment - Thank you for the quick review. Merged to master.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel