Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31616

Move basic utility code from ts_salobj to new package ts_utils

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Aug 30 - Sep 13
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Move the following out of ts_salobj into new package ts_utils:

      • time functions such as current_tai
      • angle functions such as angle_diff and angle_wrap_center
      • test utilities such as modify_environ and assert_angles_almost_equal (rename from assertAnglesAlmostEqual)
      • make_done_future

      Add trivial backward compatibility wrappers to ts_salobj that issues deprecation warnings and then call the new function in ts_utils.

      Update ts_salobj to use the new versions (but continue to test the trivial backward compatibility wrappers).

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31678 Add ts_utils to the Docker images

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31660 Remove wrappers for ts_utils functions from ts_salobj 7

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31744 Use ts_utils in ts_salobj where possible

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Pull requests:

            I filed DM-31660 to track removing the compatibility wrappers in ts_salobj.

            Show
            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_utils/pull/1 https://github.com/lsst-ts/ts_salobj/pull/205 I filed DM-31660 to track removing the compatibility wrappers in ts_salobj.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub and left a few comments for your consideration.

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub and left a few comments for your consideration.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Blocked by DM-31678: we need ts_utils to be in the Docker images before merging the ts_salobj work, else the merge Jenkins jobs for many packages.

            Show
            rowen Russell Owen added a comment - Blocked by DM-31678 : we need ts_utils to be in the Docker images before merging the ts_salobj work, else the merge Jenkins jobs for many packages.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Tiago implemented DM-31678 but has not yet marked it complete. ts_salobj Jenkins is now passing.

            Released ts_utils v1.0.0 and ts_salobj v6.6.0

            Show
            rowen Russell Owen added a comment - Tiago implemented DM-31678 but has not yet marked it complete. ts_salobj Jenkins is now passing. Released ts_utils v1.0.0 and ts_salobj v6.6.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Tiago Ribeiro, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.