Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31616

Move basic utility code from ts_salobj to new package ts_utils

    XMLWordPrintable

Details

    • 1
    • TSSW Sprint - Aug 30 - Sep 13
    • Telescope and Site
    • No

    Description

      Move the following out of ts_salobj into new package ts_utils:

      • time functions such as current_tai
      • angle functions such as angle_diff and angle_wrap_center
      • test utilities such as modify_environ and assert_angles_almost_equal (rename from assertAnglesAlmostEqual)
      • make_done_future

      Add trivial backward compatibility wrappers to ts_salobj that issues deprecation warnings and then call the new function in ts_utils.

      Update ts_salobj to use the new versions (but continue to test the trivial backward compatibility wrappers).

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment - - edited

            Pull requests:

            I filed DM-31660 to track removing the compatibility wrappers in ts_salobj.

            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_utils/pull/1 https://github.com/lsst-ts/ts_salobj/pull/205 I filed DM-31660 to track removing the compatibility wrappers in ts_salobj.

            Reviewed on GitHub and left a few comments for your consideration.

            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub and left a few comments for your consideration.
            rowen Russell Owen added a comment -

            Blocked by DM-31678: we need ts_utils to be in the Docker images before merging the ts_salobj work, else the merge Jenkins jobs for many packages.

            rowen Russell Owen added a comment - Blocked by DM-31678 : we need ts_utils to be in the Docker images before merging the ts_salobj work, else the merge Jenkins jobs for many packages.
            rowen Russell Owen added a comment -

            Tiago implemented DM-31678 but has not yet marked it complete. ts_salobj Jenkins is now passing.

            Released ts_utils v1.0.0 and ts_salobj v6.6.0

            rowen Russell Owen added a comment - Tiago implemented DM-31678 but has not yet marked it complete. ts_salobj Jenkins is now passing. Released ts_utils v1.0.0 and ts_salobj v6.6.0

            People

              rowen Russell Owen
              rowen Russell Owen
              Wouter van Reeven
              Russell Owen, Tiago Ribeiro, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.