Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31707

Remove deprecated Psf methods

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Remove Psf methods deprecated by RFC-796.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36466 Do Release 26.0.0 of Science Pipelines

          • In Progress
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31706 Do Release 24.0.0 of Science Pipelines

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-796 Default Psf position argument considered harmful

          • Adopted
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31536 Remove default implementation of Psf::getAveragePosition()

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            I think because this was announced in v23 (on the pending deprecation list), the methods have to remain as of v24 (moved to the deprecated list),  and can be removed as soon as v24_0_0_rc1 is tagged. 

            Show
            yusra Yusra AlSayyad added a comment - I think because this was announced in v23 (on the pending deprecation list), the methods have to remain as of v24 (moved to the deprecated list),  and can be removed as soon as v24_0_0_rc1 is tagged. 
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I think this is a duplicate of the older DM-31536, or at least they both refer to RFC-796.

            Show
            tjenness Tim Jenness added a comment - I think this is a duplicate of the older DM-31536 , or at least they both refer to RFC-796 .
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment -

            I took the freedom to implement this in a user branch passes lsst_distrib/ci in jenkins, could be renamed:
            https://github.com/lsst/afw/tree/u/wittgen/remove_args

            Show
            wittgen Matthias Wittgen added a comment - I took the freedom to implement this in a user branch passes lsst_distrib/ci in jenkins, could be renamed: https://github.com/lsst/afw/tree/u/wittgen/remove_args
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment -

            PR: https://github.com/lsst/afw/pull/701
            Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39166/pipeline

            Show
            wittgen Matthias Wittgen added a comment - PR: https://github.com/lsst/afw/pull/701 Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39166/pipeline
            Hide
            Permalink
            jmeyers314 Joshua Meyers added a comment -

            Thanks Matthias Wittgen. Please take a look at my github comments and address as you see fit. But looks good to me overall.

            Show
            jmeyers314 Joshua Meyers added a comment - Thanks Matthias Wittgen . Please take a look at my github comments and address as you see fit. But looks good to me overall.

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              jmeyers314 Joshua Meyers
              Reviewers:
              Joshua Meyers
              Watchers:
              Joshua Meyers, Matthias Wittgen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.