Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31721

Create cpputils package

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: utils
    • Labels:
      None
    • Story Points:
      4
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Following RFC-795 this ticket is to move all the C++ code out of the utils package and into a new cpputils package. The utils package will include deprecation notices and forwarders for the python interfaces that have moved. The c++ include files in utils will be modified to include the cpputils includes.

      This ticket may also include fixing usage of utils code that has moved in other packages.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-795 Reorganize general purpose python utility code in utils/daf_butler/pipe_base

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I've created a new repo seeded by the "utils" git repo with all the unnecessary python code stripped out. Jenkins builds it fine. Kian-Tat Lim it's done as an open pull request that I have not merged and which I assume should be reviewed before merging. I'm now going to take a quick look as to how big a job it would be to change all the packages that depend on utils to now depend on cpputils.

            Show
            tjenness Tim Jenness added a comment - I've created a new repo seeded by the "utils" git repo with all the unnecessary python code stripped out. Jenkins builds it fine. Kian-Tat Lim it's done as an open pull request that I have not merged and which I assume should be reviewed before merging. I'm now going to take a quick look as to how big a job it would be to change all the packages that depend on utils to now depend on cpputils.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim this is ready for review.

            • Moved C++ to cpputils but retained namespace of lsst::utils
            • Added github action to build and test utils.
            • Added some type annotations.
            • Changed NotFoundError to LookupError in some packages using getPackageDir
            • Added cpputils dependency to packages that use C++ utils.
            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim this is ready for review. Moved C++ to cpputils but retained namespace of lsst::utils Added github action to build and test utils. Added some type annotations. Changed NotFoundError to LookupError in some packages using getPackageDir Added cpputils dependency to packages that use C++ utils.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Overall OK, but I think you could move further towards enabling packages to start using #include "lsst/cpputils" and lsst::cpputils. Some minor questions and suggestions.

            Show
            ktl Kian-Tat Lim added a comment - Overall OK, but I think you could move further towards enabling packages to start using #include "lsst/cpputils" and lsst::cpputils . Some minor questions and suggestions.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.