Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3173

In CalibrateTask if one disables psf determination then aperture correction will fail

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      In pipe_tasks CalibrateTask, by default aperture correction uses source flag "calib_psfUsed" to decide if a source is acceptable to use for measuring aperture correction. If PSF determination is disabled then this flag is never set and aperture correction will fail with a complaint that there are 0 sources.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Implemented on pipe_tasks tickets/DM-3173

            My solution was to require that CalibrateConfig.doPsf be true if doMeasureApCorr is true and measureApCorr.inputFilterFlag == "calib_psfUsed".

            I had originally intended something slightly simpler, but working on DM-3114 convinced me that the full solution was best, because SdssCalibrateTask uses measureApCorr.inputFilterFlag == "calib_psfCandidate", the other logical choice (and one that does not require doPsf true).

            Show
            rowen Russell Owen added a comment - Implemented on pipe_tasks tickets/ DM-3173 My solution was to require that CalibrateConfig.doPsf be true if doMeasureApCorr is true and measureApCorr.inputFilterFlag == "calib_psfUsed". I had originally intended something slightly simpler, but working on DM-3114 convinced me that the full solution was best, because SdssCalibrateTask uses measureApCorr.inputFilterFlag == "calib_psfCandidate", the other logical choice (and one that does not require doPsf true).
            Hide
            jbosch Jim Bosch added a comment -

            Looks fine.

            Show
            jbosch Jim Bosch added a comment - Looks fine.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel