Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3174

CalibrateTask instantiates measureApCorr, applyApCorr and photocal subtasks using the wrong schema

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      CalibrateTask instantiates measureApCorr, applyApCorr and photocal subtasks using the initial schema "schema1" instead of the final schema. Normally this would not matter since most of the fields are shared, but aperture correction wants aperture flux at a larger radius than the narrowest option, and schema1 may only provide the narrowest option.

      In any case it is safer to instantiate those three subtasks using the final schema, since they are only ever run on the final schema. (Several other subtasks are run on both the initial and final schema, and should continue to be instantiated using schema1).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Paul, can you please look at this simple change?

            Implemented in pipe_tasks tickets/DM-3174. The only file changed is calibrate.py

            Show
            rowen Russell Owen added a comment - Paul, can you please look at this simple change? Implemented in pipe_tasks tickets/ DM-3174 . The only file changed is calibrate.py
            Hide
            price Paul Price added a comment -

            Looks good. Only comments are with regard to the commit message:

            • Summary line of the commit message doesn't describe what was changed.
            • Commit message should wrap around 72 chars or so (5th line is a bit longer).
            Show
            price Paul Price added a comment - Looks good. Only comments are with regard to the commit message: Summary line of the commit message doesn't describe what was changed. Commit message should wrap around 72 chars or so (5th line is a bit longer).
            Hide
            rowen Russell Owen added a comment -

            I modified the commit message and merged.

            Show
            rowen Russell Owen added a comment - I modified the commit message and merged.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, Paul Price, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel