Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31744

Use ts_utils in ts_salobj where possible

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      0
    • Epic Link:
    • Sprint:
      TSSW Sprint - Sep 13 - Sep 27
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      When I implemented DM-31616 move some code to new ts_utils package I thought I had switched to ts_utils everywhere in ts_salobj (aside from some tests of the deprecated wrappers for these functions in salobj). But I certainly missed some cases, including many places where make_done_future is called. Take another pass to find all such instances; use ts_utils wherever possible.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31616 Move basic utility code from ts_salobj to new package ts_utils

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I looked for all functions from ts_utils. As far as I can tell the angle functions and test utilities were all updated correctly, but there were still old uses of time functions and missing with self.assertWarns(DeprecationWarning) in unit tests that intentionally call the deprecated salobj wrappers.

            Pull request: https://github.com/lsst-ts/ts_salobj/pull/206

            Show
            rowen Russell Owen added a comment - - edited I looked for all functions from ts_utils. As far as I can tell the angle functions and test utilities were all updated correctly, but there were still old uses of time functions and missing with self.assertWarns(DeprecationWarning) in unit tests that intentionally call the deprecated salobj wrappers. Pull request: https://github.com/lsst-ts/ts_salobj/pull/206
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Released as v6.6.1

            Show
            rowen Russell Owen added a comment - Released as v6.6.1

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Watchers:
              Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.