Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31744

Use ts_utils in ts_salobj where possible

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • 0
    • TSSW Sprint - Sep 13 - Sep 27
    • Telescope and Site
    • No

    Description

      When I implemented DM-31616 move some code to new ts_utils package I thought I had switched to ts_utils everywhere in ts_salobj (aside from some tests of the deprecated wrappers for these functions in salobj). But I certainly missed some cases, including many places where make_done_future is called. Take another pass to find all such instances; use ts_utils wherever possible.

      Attachments

        Issue Links

          Activity

            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-31616 [ DM-31616 ]
            rowen Russell Owen added a comment - - edited

            I looked for all functions from ts_utils. As far as I can tell the angle functions and test utilities were all updated correctly, but there were still old uses of time functions and missing with self.assertWarns(DeprecationWarning) in unit tests that intentionally call the deprecated salobj wrappers.

            Pull request: https://github.com/lsst-ts/ts_salobj/pull/206

            rowen Russell Owen added a comment - - edited I looked for all functions from ts_utils. As far as I can tell the angle functions and test utilities were all updated correctly, but there were still old uses of time functions and missing with self.assertWarns(DeprecationWarning) in unit tests that intentionally call the deprecated salobj wrappers. Pull request: https://github.com/lsst-ts/ts_salobj/pull/206
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]

            Released as v6.6.1

            rowen Russell Owen added a comment - Released as v6.6.1

            People

              rowen Russell Owen
              rowen Russell Owen
              Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.