Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31773

Ensure visitInfo.id matches the butler visit key

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      Now that we have visitInfo.id, we need to ensure it matches the exposure/visit identifier used by the butler. Jim Bosch suggested this could be done early on in CharacterizeImageTask, and may necessitate replacing the ExposureIdInfo object entirely. CharacterizeImageTask.runQuantum would have to pass in the value of dataId['visit'] to run.

      Because we named the VisitInfo object simply id, we can put either the exposure or visit butler id in there, depending on whether we are working on a snap or visit. Since we have no snap handling code right now, we can just use visit currently.

      Once this is done, we can clean up other Tasks that override runQuantum to get the visit id (many of these in the AP pipelines), and have them just use visitInfo.id

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13944 add id to VisitInfo

          • Done
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-459 Remove exposureId from VisitInfo and add visitId

          • Implemented

            Activity

            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Perhaps as part of this we should update the VisitInfo docs? "Identifier of this full focal plane data" is not helpful for either clients that create a VisitInfo or that try to read one.

            E.g.,

            If the exposure is a Butler dataset, then this identifier must equal the Butler visit ID for a visit-level dataset, or the exposure ID for an exposure-level dataset. The identifier may be any unique value for other datasets, such as coadds.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Perhaps as part of this we should update the VisitInfo docs ? "Identifier of this full focal plane data" is not helpful for either clients that create a VisitInfo or that try to read one. E.g., If the exposure is a Butler dataset, then this identifier must equal the Butler visit ID for a visit-level dataset, or the exposure ID for an exposure-level dataset. The identifier may be any unique value for other datasets, such as coadds.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eli Rykoff, Hsin-Fang Chiang, Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.