Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31773

Ensure visitInfo.id matches the butler visit key

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      Now that we have visitInfo.id, we need to ensure it matches the exposure/visit identifier used by the butler. Jim Bosch suggested this could be done early on in CharacterizeImageTask, and may necessitate replacing the ExposureIdInfo object entirely. CharacterizeImageTask.runQuantum would have to pass in the value of dataId['visit'] to run.

      Because we named the VisitInfo object simply id, we can put either the exposure or visit butler id in there, depending on whether we are working on a snap or visit. Since we have no snap handling code right now, we can just use visit currently.

      Once this is done, we can clean up other Tasks that override runQuantum to get the visit id (many of these in the AP pipelines), and have them just use visitInfo.id

        Attachments

          Issue Links

            Activity

            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue is blocked by DM-13944 [ DM-13944 ]
            Parejkoj John Parejko made changes -
            Watchers Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness [ Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness ] Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness, Yusra AlSayyad [ Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness, Yusra AlSayyad ]
            Parejkoj John Parejko made changes -
            Link This issue relates to RFC-459 [ RFC-459 ]
            Parejkoj John Parejko made changes -
            Description Now that we have {{visitInfo.id}}, we need to ensure it matches the visit identifier used by the butler. [~jbosch] suggested this could be done early on in CharacterizeImageTask, and may necessitate replacing the ExposureIdInfo object entirely. {{CharacterizeImageTask.runQuantum}} would have to pass in the value of {{dataId['visit']}} to {{run}}.

            Once this is done, we can clean up other Tasks that override {{runQuantum}} to get the visit id (many of these in the AP pipelines), and have them just use {{visitInfo.id}}
            Now that we have {{visitInfo.id}}, we need to ensure it matches the exposure/visit identifier used by the butler. [~jbosch] suggested this could be done early on in CharacterizeImageTask, and may necessitate replacing the ExposureIdInfo object entirely. {{CharacterizeImageTask.runQuantum}} would have to pass in the value of {{dataId['visit']}} to {{run}}.

            Because we named the {{VisitInfo}} object simply {{id}}, we can put either the {{exposure}} or {{visit}} butler id in there, depending on whether we are working on a snap or visit. Since we have no snap handling code right now, we can just use {{visit}} currently.

            Once this is done, we can clean up other Tasks that override {{runQuantum}} to get the visit id (many of these in the AP pipelines), and have them just use {{visitInfo.id}}
            sullivan Ian Sullivan made changes -
            Labels SciencePipelines SciencePipelines ap-analysis
            sullivan Ian Sullivan made changes -
            Rank Ranked higher

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.