Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31786

Update linting workflow in www_lsst_io

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: www_lsst_io
    • Labels:
      None

      Description

      Currently the linting in www_lsst_io is out of sync because pre-commit is out of sync with the package's own npm-based eslint/prettier configuration. Further, there is a new style of configuration for eslint and prettier where prettier is run independently of eslint. The purpose of this ticket is to clean up the linting workflows in www_lsst_io so that we can develop more effectively.

        Attachments

          Issue Links

            Activity

            Hide
            jsick Jonathan Sick added a comment -

            Outcome:

            First, update all dependencies to their latest versions.

            Eslint and prettier now run separately, which is the recommended method. As part of this, we're dropping the usage of the wesbos eslint config because that was stopping us from using eslint 7. I've ported in the basic eslint config that we got from the wesbos config.

            As well, instead of using pre-commit and Python to run git hooks, we're using husky.

            Show
            jsick Jonathan Sick added a comment - Outcome: First, update all dependencies to their latest versions. Eslint and prettier now run separately, which is the recommended method. As part of this, we're dropping the usage of the wesbos eslint config because that was stopping us from using eslint 7. I've ported in the basic eslint config that we got from the wesbos config. As well, instead of using pre-commit and Python to run git hooks, we're using husky.

              People

              Assignee:
              jsick Jonathan Sick
              Reporter:
              jsick Jonathan Sick
              Watchers:
              Jonathan Sick
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.