Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31801

Ensure all loggers include lsst prefix

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_base
    • Labels:
      None
    • Story Points:
      8
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Ensure that all the loggers created for tasks include the lsst prefix.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-32143 Gen 3 ap_verify ingestion does not produce logs

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31802 Migrate standalone loggers to use lsst prefix

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-801 Use lsst prefix in logger names

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-801 [ RFC-801 ]
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'm sending out reviews as I do individual packages and I'm trying to spread the load so that lots of people have small reviews rather than one person having to look at many packages.

            Show
            tjenness Tim Jenness added a comment - I'm sending out reviews as I do individual packages and I'm trying to spread the load so that lots of people have small reviews rather than one person having to look at many packages.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'm spreading this review out so as not to swamp a single person. The code changes are fairly trivial so hopefully reviews won't take long.

            Thanks for Arun Kannawadi, Eli Rykoff, Dan Taranu, Lauren MacArthur, Angelo Fausti, Krzysztof Findeisen, and Fred Moolekamp for doing reviews as I went along.

            Show
            tjenness Tim Jenness added a comment - I'm spreading this review out so as not to swamp a single person. The code changes are fairly trivial so hopefully reviews won't take long. obs_decam: Meredith Rawls ip_diffim: Ian Sullivan meas_astrom: John Parejko meas_deblender: Lauren MacArthur pipe_base: Kian-Tat Lim jointcal: John Parejko obs_base: Andy Salnikov afw: Andy Salnikov meas_algorithms: Nate Lust cp_pipe: Christopher Waters or Andrés Alejandro Plazas Malagón ctrl_mpexec: Andy Salnikov Thanks for Arun Kannawadi , Eli Rykoff , Dan Taranu , Lauren MacArthur , Angelo Fausti , Krzysztof Findeisen , and Fred Moolekamp for doing reviews as I went along.
            tjenness Tim Jenness made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls, Nate Lust [ plazas, salnikov, cwaters, sullivan, parejkoj, ktl, lauren, mrawls, nlust ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            nlust Nate Lust made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls, Nate Lust [ plazas, salnikov, cwaters, sullivan, parejkoj, ktl, lauren, mrawls, nlust ] Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, sullivan, parejkoj, ktl, lauren, mrawls ]
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Minor comment, took myself off reviewers.

            Show
            nlust Nate Lust added a comment - Minor comment, took myself off reviewers.
            sullivan Ian Sullivan made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, sullivan, parejkoj, ktl, lauren, mrawls ] Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, parejkoj, ktl, lauren, mrawls ]
            salnikov Andy Salnikov made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, parejkoj, ktl, lauren, mrawls ] Andrés Alejandro Plazas Malagón, Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, cwaters, parejkoj, ktl, lauren, mrawls ]
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Few minor comments, removed myself from reviewers.

            Show
            salnikov Andy Salnikov added a comment - Few minor comments, removed myself from reviewers.
            Hide
            Permalink
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited

            I looked at cp_pipe; it looks good. I just had a question regarding f-strings in the log messages. I'll remove myself from the list of reviewers.

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited I looked at cp_pipe ; it looks good. I just had a question regarding f-strings in the log messages. I'll remove myself from the list of reviewers.
            plazas Andrés Alejandro Plazas Malagón made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, cwaters, parejkoj, ktl, lauren, mrawls ] Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ cwaters, parejkoj, ktl, lauren, mrawls ]
            Parejkoj John Parejko made changes -
            Reviewers Christopher Waters, John Parejko, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ cwaters, parejkoj, ktl, lauren, mrawls ] Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, sullivan, ktl, lauren, mrawls ]
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I've looked over cp_pipe and ip_isr and both look fine.

            Show
            czw Christopher Waters added a comment - I've looked over cp_pipe and ip_isr and both look fine.
            czw Christopher Waters made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, cwaters, sullivan, ktl, lauren, mrawls ] Andrés Alejandro Plazas Malagón, Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, sullivan, ktl, lauren, mrawls ]
            tjenness Tim Jenness made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ plazas, salnikov, sullivan, ktl, lauren, mrawls ] Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ salnikov, sullivan, ktl, lauren, mrawls ]
            mrawls Meredith Rawls made changes -
            Reviewers Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur, Meredith Rawls [ salnikov, sullivan, ktl, lauren, mrawls ] Andrés Alejandro Plazas Malagón, Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur [ plazas, salnikov, sullivan, ktl, lauren ]
            tjenness Tim Jenness made changes -
            Reviewers Andrés Alejandro Plazas Malagón, Andy Salnikov, Ian Sullivan, Kian-Tat Lim, Lauren MacArthur [ plazas, salnikov, sullivan, ktl, lauren ] Kian-Tat Lim, Lauren MacArthur, Lee Kelvin [ ktl, lauren, lskelvin ]
            tjenness Tim Jenness made changes -
            Reviewers Kian-Tat Lim, Lauren MacArthur, Lee Kelvin [ ktl, lauren, lskelvin ] Kian-Tat Lim, Lauren MacArthur, Lee Kelvin, Meredith Rawls [ ktl, lauren, lskelvin, mrawls ]
            tjenness Tim Jenness made changes -
            Reviewers Kian-Tat Lim, Lauren MacArthur, Lee Kelvin, Meredith Rawls [ ktl, lauren, lskelvin, mrawls ] Kian-Tat Lim, Lauren MacArthur, Lee Kelvin [ ktl, lauren, lskelvin ]
            ktl Kian-Tat Lim made changes -
            Reviewers Kian-Tat Lim, Lauren MacArthur, Lee Kelvin [ ktl, lauren, lskelvin ] Lauren MacArthur, Lee Kelvin [ lauren, lskelvin ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            pipe_base is OK, with one minor comment.

            Show
            ktl Kian-Tat Lim added a comment - pipe_base is OK, with one minor comment.
            lskelvin Lee Kelvin made changes -
            Reviewers Lauren MacArthur, Lee Kelvin [ lauren, lskelvin ] Lauren MacArthur [ lauren ]
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Just one minor comment re: string syntax in meas_deblender, but otherwise looks good to me - thanks Tim!

            Show
            lskelvin Lee Kelvin added a comment - Just one minor comment re: string syntax in meas_deblender , but otherwise looks good to me - thanks Tim!
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thank you everyone. I think that's all reviews in. I really do appreciate the speed.

            Show
            tjenness Tim Jenness added a comment - Thank you everyone. I think that's all reviews in. I really do appreciate the speed.
            tjenness Tim Jenness made changes -
            Summary Ensure Task loggers include lsst prefix Ensure all loggers include lsst prefix
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            You got an efficient set of reviewers indeed, and I will take the honour of officially hitting the button (with the requisite “as long as Jenkins is happy” clause)!

            Show
            lauren Lauren MacArthur added a comment - You got an efficient set of reviewers indeed, and I will take the honour of officially hitting the button (with the requisite “as long as Jenkins is happy” clause)!
            lauren Lauren MacArthur made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue is duplicated by DM-32143 [ DM-32143 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Link This issue is duplicated by DM-31802 [ DM-31802 ]
            tjenness Tim Jenness made changes -
            Story Points 8

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Lauren MacArthur
              Watchers:
              Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Lee Kelvin, Meredith Rawls, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.