Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31801

Ensure all loggers include lsst prefix

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_base
    • Labels:
      None
    • Story Points:
      8
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Ensure that all the loggers created for tasks include the lsst prefix.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I'm sending out reviews as I do individual packages and I'm trying to spread the load so that lots of people have small reviews rather than one person having to look at many packages.

            Show
            tjenness Tim Jenness added a comment - I'm sending out reviews as I do individual packages and I'm trying to spread the load so that lots of people have small reviews rather than one person having to look at many packages.
            Hide
            tjenness Tim Jenness added a comment -

            I'm spreading this review out so as not to swamp a single person. The code changes are fairly trivial so hopefully reviews won't take long.

            Thanks for Arun Kannawadi, Eli Rykoff, Dan Taranu, Lauren MacArthur, Angelo Fausti, Krzysztof Findeisen, and Fred Moolekamp for doing reviews as I went along.

            Show
            tjenness Tim Jenness added a comment - I'm spreading this review out so as not to swamp a single person. The code changes are fairly trivial so hopefully reviews won't take long. obs_decam: Meredith Rawls ip_diffim: Ian Sullivan meas_astrom: John Parejko meas_deblender: Lauren MacArthur pipe_base: Kian-Tat Lim jointcal: John Parejko obs_base: Andy Salnikov afw: Andy Salnikov meas_algorithms: Nate Lust cp_pipe: Christopher Waters or Andrés Alejandro Plazas Malagón ctrl_mpexec: Andy Salnikov Thanks for Arun Kannawadi , Eli Rykoff , Dan Taranu , Lauren MacArthur , Angelo Fausti , Krzysztof Findeisen , and Fred Moolekamp for doing reviews as I went along.
            Hide
            nlust Nate Lust added a comment -

            Minor comment, took myself off reviewers.

            Show
            nlust Nate Lust added a comment - Minor comment, took myself off reviewers.
            Hide
            salnikov Andy Salnikov added a comment -

            Few minor comments, removed myself from reviewers.

            Show
            salnikov Andy Salnikov added a comment - Few minor comments, removed myself from reviewers.
            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited

            I looked at cp_pipe; it looks good. I just had a question regarding f-strings in the log messages. I'll remove myself from the list of reviewers.

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited I looked at cp_pipe ; it looks good. I just had a question regarding f-strings in the log messages. I'll remove myself from the list of reviewers.
            Hide
            czw Christopher Waters added a comment -

            I've looked over cp_pipe and ip_isr and both look fine.

            Show
            czw Christopher Waters added a comment - I've looked over cp_pipe and ip_isr and both look fine.
            Hide
            ktl Kian-Tat Lim added a comment -

            pipe_base is OK, with one minor comment.

            Show
            ktl Kian-Tat Lim added a comment - pipe_base is OK, with one minor comment.
            Hide
            lskelvin Lee Kelvin added a comment -

            Just one minor comment re: string syntax in meas_deblender, but otherwise looks good to me - thanks Tim!

            Show
            lskelvin Lee Kelvin added a comment - Just one minor comment re: string syntax in meas_deblender , but otherwise looks good to me - thanks Tim!
            Hide
            tjenness Tim Jenness added a comment -

            Thank you everyone. I think that's all reviews in. I really do appreciate the speed.

            Show
            tjenness Tim Jenness added a comment - Thank you everyone. I think that's all reviews in. I really do appreciate the speed.
            Hide
            lauren Lauren MacArthur added a comment -

            You got an efficient set of reviewers indeed, and I will take the honour of officially hitting the button (with the requisite “as long as Jenkins is happy” clause)!

            Show
            lauren Lauren MacArthur added a comment - You got an efficient set of reviewers indeed, and I will take the honour of officially hitting the button (with the requisite “as long as Jenkins is happy” clause)!

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Lauren MacArthur
              Watchers:
              Andrés Alejandro Plazas Malagón, Andy Salnikov, Christopher Waters, Ian Sullivan, John Parejko, Kian-Tat Lim, Lauren MacArthur, Lee Kelvin, Meredith Rawls, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.