Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: cp_pipe
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
The PTC finalMeans , finalVars , and covariances are read in for the BFK calculation, along with the expIdMask. expIdMask indexes the full list of means (rawMeans), but this has already been filtered by the time it is saved as the finalMeans. This results in a length mismatch and IndexError exception.
Attachments
Activity
Thank you for this fix. Did you test it for all three types of fits in the PTC code (POLYNOMIAL, EXPAPPROXIMATION, FULLCOVARIANCE)?
If there's something that could be made more consistent in the PTC code (regarding the length of the expId mask and the final arrays for each type of model that could be fitted in the `solve` task), I would like to have it captured here in a ticket (maybe DM-31896? or a new ticket)
I've tested that all three types of PTC work with the BFK code on this branch.
As for making it more consistent: it might be worth adding this kind of feature to the PTC dataset itself; when it unpacks the amplifier entries, it might be best to remove the padded entries. I think this would make len(finalMeans) = len(finalVars) = len(covariances) for any amplifier. This would require repadding if it's rewritten, but I'm not sure that's something that happens.
I've added a ticket (DM-31938) if you think that's worth doing.
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35042/pipeline