Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31817

Remove default value on DatasetConfig.ref_dataset_name

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      In gen3, the DatasetConfig.ref_dataset_name value must match the DatasetType name of the refcat, and the refcat config.py is no longer checked: LoadIndexedReferenceObjectsConfig only applies to the gen2 loader. The default value of cal_ref_cat here has caused a variety of confusion over the years, and we don't want any gen3 refcats with that name: the gen3 refcat convert script provides the dataset registration and ingest commands to run post-conversion, which includes this field for the DatasetType.

      Once gen2 is gone, we can safely remove the default value on this field (we can't easily do it beforehand: I tried).

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35671 Remove gen2 support from meas_algorithms

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29543 Gen3 refcat converter

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31698 Move ConvertReferenceCatalog classes out of ingestIndex file

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35671 Remove gen2 support from meas_algorithms

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35871 Add refcat name arg to ReferenceObjectLoader init

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Gen2 is now gone.

            Show
            tjenness Tim Jenness added a comment - Gen2 is now gone.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Doing this on DM-31698.

            Show
            Parejkoj John Parejko added a comment - Doing this on DM-31698 .

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eli Rykoff, Ian Sullivan, John Parejko, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.