Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31869

Remove computeShape calls without argument in GAaP

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      In response to RFC-796, remove any remaining calls to `computeShape` for PSFs made in GAaP

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          The gaap changes look good with a small comment; I would recommend also fixing the test code in meas_base on this ticket that throw the same warnings when running the meas_extensions_gaap tests: https://github.com/lsst/meas_base/blob/7290ee3df76d4c86d446237cb88f09a357d950f0/python/lsst/meas/base/tests.py#L386

          Show
          erykoff Eli Rykoff added a comment - The gaap changes look good with a small comment; I would recommend also fixing the test code in meas_base on this ticket that throw the same warnings when running the meas_extensions_gaap tests: https://github.com/lsst/meas_base/blob/7290ee3df76d4c86d446237cb88f09a357d950f0/python/lsst/meas/base/tests.py#L386
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          Done and ready, pending a clean jenkins.

          Show
          erykoff Eli Rykoff added a comment - Done and ready, pending a clean jenkins.
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Thanks a lot for the review, Eli! Successful Jenkins build: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35023/pipeline/

          Show
          kannawad Arun Kannawadi added a comment - Thanks a lot for the review, Eli! Successful Jenkins build:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35023/pipeline/

            People

            Assignee:
            kannawad Arun Kannawadi
            Reporter:
            kannawad Arun Kannawadi
            Reviewers:
            Eli Rykoff
            Watchers:
            Arun Kannawadi, Eli Rykoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.