Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31903

Add update kwargs/option to instrument registration

    XMLWordPrintable

    Details

      Description

      Registry already has an update kwarg in syncDimensionData.  Add options to forward that from instrument registration methods and command-lines, for at least the dimension record itself, and maybe detectors, too.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31890 Attempt to re-register the LATISS instrument with butler register-instrument fails for /repo/main

          • To Do
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31915 ci_builder should not be using script subpackages

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Link This issue blocks DM-31890 [ DM-31890 ]
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Story Points 2 1
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Mikolaj Kowalik, here's the functionality we need to fix DM-31890; just a bunch of update keyword argument forwarding down to existing code that does the real work in daf_butler.

            I've made this a separate ticket so we can get the functionality in before we figure out how best to use it.

            PRs are:

            Jenkins in progress at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35040/pipeline

             

            Show
            jbosch Jim Bosch added a comment - Mikolaj Kowalik , here's the functionality we need to fix DM-31890 ; just a bunch of update keyword argument forwarding down to existing code that does the real work in daf_butler. I've made this a separate ticket so we can get the functionality in before we figure out how best to use it. PRs are: https://github.com/lsst/obs_base/pull/389 https://github.com/lsst/obs_cfht/pull/92 https://github.com/lsst/obs_decam/pull/201 https://github.com/lsst/obs_lsst/pull/350 https://github.com/lsst/obs_subaru/pull/389 Jenkins in progress at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35040/pipeline  
            jbosch Jim Bosch made changes -
            Reviewers Mikolaj Kowalik [ mkowalik ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            mkowalik Mikolaj Kowalik added a comment -

            Looks good to me.

            Show
            mkowalik Mikolaj Kowalik added a comment - Looks good to me.
            mkowalik Mikolaj Kowalik made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I think this may have broken ci_imsim:

            ci_imsim: master-gae7f014c18+24a0f2a041 ........:::::  [2021-09-25T03:46:59.931347Z] lsst.ci.builder.CommandRunner INFO: Running CI command: butler
            		 
            :::::  [2021-09-25T03:47:01.414434Z] lsst.ci.builder.CommandRunner INFO: Running CI command: instrument
            		 
            :::::  [2021-09-25T03:47:01.469462Z] Traceback (most recent call last):
            		 
            :::::  [2021-09-25T03:47:01.469533Z]   File "bin/ci_imsim_run.py", line 165, in <module>
            		 
            :::::  [2021-09-25T03:47:01.469542Z]     ciRunner.run()
            		 
            :::::  [2021-09-25T03:47:01.469548Z]   File "/j/ws/stack-os-matrix/centos-7-conda/lsstsw/stack/lsst-scipipe-0.7.0/Linux64/ci_builder/master-ge5c0ca04d4+348f55c77c/python/lsst/ci/builder/ciBuilderLib.py", line 443, in run
            		 
            :::::  [2021-09-25T03:47:01.469555Z]     cmd.run(self.getRepoState())
            		 
            :::::  [2021-09-25T03:47:01.469560Z]   File "/j/ws/stack-os-matrix/centos-7-conda/lsstsw/stack/lsst-scipipe-0.7.0/Linux64/ci_builder/master-ge5c0ca04d4+348f55c77c/python/lsst/ci/builder/commands.py", line 37, in run
            		 
            :::::  [2021-09-25T03:47:01.469566Z]     registerInstrument(self.runner.RunDir, instrument)
            		 
            :::::  [2021-09-25T03:47:01.469571Z] TypeError: registerInstrument() missing 1 required positional argument: 'update'

            Show
            tjenness Tim Jenness added a comment - I think this may have broken ci_imsim: ci_imsim: master-gae7f014c18+24a0f2a041 ........::::: [2021-09-25T03:46:59.931347Z] lsst.ci.builder.CommandRunner INFO: Running CI command: butler ::::: [2021-09-25T03:47:01.414434Z] lsst.ci.builder.CommandRunner INFO: Running CI command: instrument ::::: [2021-09-25T03:47:01.469462Z] Traceback (most recent call last): ::::: [2021-09-25T03:47:01.469533Z] File "bin/ci_imsim_run.py", line 165, in <module> ::::: [2021-09-25T03:47:01.469542Z] ciRunner.run() ::::: [2021-09-25T03:47:01.469548Z] File "/j/ws/stack-os-matrix/centos-7-conda/lsstsw/stack/lsst-scipipe-0.7.0/Linux64/ci_builder/master-ge5c0ca04d4+348f55c77c/python/lsst/ci/builder/ciBuilderLib.py", line 443, in run ::::: [2021-09-25T03:47:01.469555Z] cmd.run(self.getRepoState()) ::::: [2021-09-25T03:47:01.469560Z] File "/j/ws/stack-os-matrix/centos-7-conda/lsstsw/stack/lsst-scipipe-0.7.0/Linux64/ci_builder/master-ge5c0ca04d4+348f55c77c/python/lsst/ci/builder/commands.py", line 37, in run ::::: [2021-09-25T03:47:01.469566Z] registerInstrument(self.runner.RunDir, instrument) ::::: [2021-09-25T03:47:01.469571Z] TypeError: registerInstrument() missing 1 required positional argument: 'update'
            tjenness Tim Jenness made changes -
            Link This issue is triggering DM-31915 [ DM-31915 ]
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Jim patched this at https://github.com/lsst/obs_base/commit/59bf8978fa642a6f3ca3f6db606aa853893c7e6b early Saturday morning.

            Show
            erykoff Eli Rykoff added a comment - Jim patched this at https://github.com/lsst/obs_base/commit/59bf8978fa642a6f3ca3f6db606aa853893c7e6b early Saturday morning.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Mikolaj Kowalik
              Watchers:
              Eli Rykoff, Jim Bosch, Mikolaj Kowalik, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.