Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31908

ltd-conveyor: re-validate compatibility with GitHub Actions-based PR runs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I'm seeing reports that the work inĀ DM-31791 did not, in fact, correctly add compatibility for PR-based runs. It's possible that the format of GITHUB_HEAD_REF is not as expected, compared to GITHUB_REF.

        Attachments

          Issue Links

            Activity

            Hide
            jsick Jonathan Sick added a comment -

            The issue was that on a pull_request trigger we use a separate GitHub environment variable (GITHUB_HEAD_REF) than on a push event (GITHUB_REF). The GITHUB_REF variable is formatted as refs/heads/branch-name, whereas the GITHUB_HEAD_REF variable is just branch-name.

            I've fixed this in ltd-conveyor 0.8.1, which is now on PyPI. I also looked into updating the conda-forge release, but that infrastructure is broken at the moment and appears to be a substantial project to debug.

            Show
            jsick Jonathan Sick added a comment - The issue was that on a pull_request trigger we use a separate GitHub environment variable ( GITHUB_HEAD_REF ) than on a push event (GITHUB_REF). The GITHUB_REF variable is formatted as refs/heads/branch-name, whereas the GITHUB_HEAD_REF variable is just branch-name. I've fixed this in ltd-conveyor 0.8.1, which is now on PyPI. I also looked into updating the conda-forge release, but that infrastructure is broken at the moment and appears to be a substantial project to debug.

              People

              Assignee:
              jsick Jonathan Sick
              Reporter:
              jsick Jonathan Sick
              Watchers:
              Jonathan Sick
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.