Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_integration, ts_qa
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:TSSW Sprint - Sep 27 - Oct 11
-
Team:Telescope and Site
-
Urgent?:No
Description
Create a script base Class, to reduce duplication of code when creating the various integration test script classes. Creating the ScriptQueue remote and pausing, adding, and resuming the ScriptQueue are things every integration test will do. Put that functionality into a base Class.
Make the ScriptQueueController Class and the script Base Class configurable so the Index (MT or AT) can be set.
Attachments
Issue Links
- has to be done before
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Make the ScriptQueueController Class configurable so the Index (MT or AT) can be set. |
| Description |
Make the ScriptQueueController Class configurable so the Index (MT or AT) can be set. |
Make the ScriptQueueController Class and the script Base Class configurable so the Index (MT or AT) can be set. |
| Epic Link |
|
| Story Points | 2 |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Michael Reuter [ mareuter ] |
| Description |
Make the ScriptQueueController Class and the script Base Class configurable so the Index (MT or AT) can be set. |
Create a script base Class, to reduce duplication of code when creating the various integration test script classes. Creating the ScriptQueue remote and pausing, adding, and resuming the ScriptQueue are things every integration test will do. Put that functionality into a base Class.
Make the ScriptQueueController Class and the script Base Class configurable so the Index (MT or AT) can be set. |
Managed to create the base Class and do the parameterization of the index variable.
https://github.com/lsst-ts/ts_IntegrationTests/pull/6
As discussed with Michael Reuter, there's some significant restructuring we want to do, to allow for multiple scripts with multiple configurations. Additionally, as currently setup, multiple ScriptQueue Remotes are created, which is wholly unnecessary.
I will use DM-31928 as the task to address the restructuring, as that task is to add the next round of configurations; multiple configurations for the same script.
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
PR reviewed.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Story Points | 2 | 3 |
| Component/s | ts_integration [ 19201 ] | |
| Component/s | ts_qa [ 16723 ] |
| Labels | Integration |
Watched several tutorials on Classes and OOP as part of this effort. And oh boy, did I learn a lot.