Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_integration, ts_qa
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:TSSW Sprint - Sep 27 - Oct 11
-
Team:Telescope and Site
-
Urgent?:No
Description
This task covers the effort to add the additional AuxTelVisit integration test configurations.
It will also cover the effort to restructure the BaseScript class to better handle multiple configurations and multiple scripts. Currently, the run command is setup with only one script and one configuration. To run multiple scripts the run command must be called multiple times. This has a lot of unnecessary overhead (starting and stopping the ScriptQueue remote each time).
Attachments
Issue Links
- has to be done after
-
- Done
- has to be done before
-
- Done
- is cloned by
-
- Done
Activity
After much research and many discussions, the initial approach I tried will not work. I tried splitting up the run method into multiple methods and attributes. This proved untenable with asyncio and syncing with the ScriptQueue remote.
I learned about asyncio and Classes and Python programming in general, along the way. But ultimately, the initial approach just won't work.
Instead, I'm going to leave the current series of steps in the run function as is, but I'm going to define the script and config parameters as Class attribute tuples and iterate the add command over them. This work will be tracked by DM-32085.
A good learning experience.
Thanks for trying the design in spite of it ultimately not working. That's the way software development goes sometimes.
https://github.com/lsst-ts/ts_IntegrationTests/tree/tickets/DM-31928https://github.com/lsst-ts/ts_IntegrationTests/tree/tickets/DM-31928_bad