Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-31934

Replace HH:MM:SS conversion code with astropy equivalents.

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_association
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Remove the custom coordinate conversion code in EphemerisQuery and replace it with equivalent code from astropy.

      Additionally, test if astropy.Table can read the data returned by SkyBot.

        Attachments

          Issue Links

          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34693 Investigate lack of solar system matches in ap_verify runs

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31026 Create Ephemeris Cache Precomputation Task for SSO attribution pipeline

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            eggl Siegfried Eggl added a comment -

            Custom coordinate conversion in skyBotEphemerisQuery (formerly known as EphemerisQuery) is now substituted with astropy.SkyCoord. SkyBot returns data in votable format that should be readable with astropy.Table in principle. Tried that but ran into a TypeError: expected bytes, str found. In any case the votable xml file would be larger than the text file that is currently returned by SkyBot and would take longer to parse. Suggest we stay with pandas.read_csv for now.  Chris Morrison [X] : could you please give it a trial run to see if everything works as it should?

            Show
            eggl Siegfried Eggl added a comment - Custom coordinate conversion in skyBotEphemerisQuery (formerly known as EphemerisQuery) is now substituted with astropy.SkyCoord. SkyBot returns data in votable format that should be readable with astropy.Table in principle. Tried that but ran into a TypeError: expected bytes, str found. In any case the votable xml file would be larger than the text file that is currently returned by SkyBot and would take longer to parse. Suggest we stay with pandas.read_csv for now.   Chris Morrison [X]  : could you please give it a trial run to see if everything works as it should?
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Hi Krzysztof Findeisen, can you review this? I think let's skip changing the parsing of the returned result at least for now, given the issues Siegfried Eggl encountered.

            Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36619/pipeline

            Show
            ebellm Eric Bellm added a comment - Hi Krzysztof Findeisen , can you review this? I think let's skip changing the parsing of the returned result at least for now, given the issues Siegfried Eggl encountered. Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36619/pipeline

              People

              Assignee:
              eggl Siegfried Eggl
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen, Siegfried Eggl
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.