Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32056

Fix mock rotator bin script; ditch host argument to mock controllers

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      TSSW Sprint - Sep 27 - Oct 11
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Remove the host argument to mock controllers.
      Fix the bin scripts that run mock controllers (specify the port, not the host).
      Fix description of port in the config schemas: the port is the telemetry port, and command is one larger. I had them reversed.

      Also:

      • Add a Jenkinsfile to ts_hexrotcomm
      • Modernize the unit tests to use bare asserts and pytest methods
      • Fix specified version of ts_rotator_controller in ts_mtrotator version history

        Attachments

          Activity

          Show
          rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_hexrotcomm/pull/44 https://github.com/lsst-ts/ts_mthexapod/pull/54 https://github.com/lsst-ts/ts_mtrotator/pull/53
          Hide
          ttsai Te-Wei Tsai added a comment -

          Reviewed in GitHub.

          Show
          ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.
          Hide
          rowen Russell Owen added a comment -

          I merged all three pull requests to develop but did not tag new releases. I am waiting until we can test this code with real hardware. I fully expect some additional changes before we make the release (including possibly getting rid of the sync patterns).

          Show
          rowen Russell Owen added a comment - I merged all three pull requests to develop but did not tag new releases. I am waiting until we can test this code with real hardware. I fully expect some additional changes before we make the release (including possibly getting rid of the sync patterns).

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Te-Wei Tsai
            Watchers:
            Russell Owen, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.