Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32062

Fix ap_verify with gen2 butler after APDB update

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DB_F21_06
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      DM-31458 had one unexpected consequence - it broke ap_verify in gen2 mode. The reason is that Apdb is trying to use polymorphic config object and that config is stored in Butler, but gen2 Butler does not support polymorphic pex_config types. One option that I like most for is to add support for polymophism to gen2 Butler similarly to how it is done in gen3 formatters.

       

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            Ready for review, Jenkins is still running, will wait until it finishes. This adds a direct dependency on pex_config which was not there before.

            Show
            salnikov Andy Salnikov added a comment - Ready for review, Jenkins is still running, will wait until it finishes. This adds a direct dependency on pex_config which was not there before.
            Hide
            salnikov Andy Salnikov added a comment -

            Jenkins finished OK.

            Show
            salnikov Andy Salnikov added a comment - Jenkins finished OK.
            Hide
            ktl Kian-Tat Lim added a comment -

            Looks OK. The extra dependency shouldn't be a problem in the short remaining lifetime of this code.

            Show
            ktl Kian-Tat Lim added a comment - Looks OK. The extra dependency shouldn't be a problem in the short remaining lifetime of this code.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Andy Salnikov, Kian-Tat Lim, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.