Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32075

Official release jobs are generating stacks with inconsistent eups versions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jenkins
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The release process is creating a manifest that uses eups package versions that include 22.0.1 (e.g. versiondb b5788). But when it later goes to do builds, those stacks seem to setup some packages with versions that use 22.0.0 (and do not include the build tag such as b5789). This carries over to the publish step and the exact versions in expanded table files, causing simple setup commands to fail in the resulting containers.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            Basically, --points-at returns nothing.

            $ git tag -l "[0-9.]*" --points-at v23.0.0.rc1
            $ git tag -l "[0-9.]*" --contains v23.0.0.rc1
            22.0.0
            22.0.1
            $ git tag -l "[0-9]*" --points-at $(git rev-parse "v23.0.0.rc1^{commit}")
            22.0.0
            22.0.1
            

            It looks like bare --points-at would return the tag specified (and only that tag) if it matched the pattern, but that's not what is desired anyway. I believe this has to do with the difference between <object> and <ref> or <commit> as a git argument.

            On the other hand, I'm now convinced that --contains is incorrect as well, as it will list later tags that contain the given ref, but those are inappropriate for versioning use. So I think we're down to the last alternative.

            Show
            ktl Kian-Tat Lim added a comment - Basically, --points-at returns nothing. $ git tag -l "[0-9.]*" --points-at v23.0.0.rc1 $ git tag -l "[0-9.]*" --contains v23.0.0.rc1 22.0.0 22.0.1 $ git tag -l "[0-9]*" --points-at $(git rev-parse "v23.0.0.rc1^{commit}") 22.0.0 22.0.1 It looks like bare --points-at would return the tag specified (and only that tag) if it matched the pattern, but that's not what is desired anyway. I believe this has to do with the difference between <object> and <ref> or <commit> as a git argument. On the other hand, I'm now convinced that --contains is incorrect as well, as it will list later tags that contain the given ref, but those are inappropriate for versioning use. So I think we're down to the last alternative.
            Show
            ktl Kian-Tat Lim added a comment - This is now https://github.com/RobertLuptonTheGood/eups/pull/147
            Hide
            tjenness Tim Jenness added a comment -

            Looks okay since it seems to work. Do you need me to hit the merge button on github?

            Show
            tjenness Tim Jenness added a comment - Looks okay since it seems to work. Do you need me to hit the merge button on github?
            Hide
            ktl Kian-Tat Lim added a comment -

            Yes, please, and a release, too.

            Show
            ktl Kian-Tat Lim added a comment - Yes, please, and a release, too.
            Hide
            tjenness Tim Jenness added a comment -

            New release pushed.

            Show
            tjenness Tim Jenness added a comment - New release pushed.

              People

              Assignee:
              ktl Kian-Tat Lim
              Reporter:
              ktl Kian-Tat Lim
              Reviewers:
              Tim Jenness
              Watchers:
              Kian-Tat Lim, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.