Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32135

Error in jointcal init when removing unneeded metrics

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:

      Description

      Kian-Tat Lim reported the following error when running verify_drp_metrics:

      Traceback (most recent call last):
      		 
          taskDefs.append(TaskDef(taskName=taskName, config=config, taskClass=taskClass, label=label))
      		 
        File "/opt/lsst/software/stack/stack/miniconda3-py38_4.9.2-0.7.0/Linux64/pipe_base/22.0.1-28-g0f96081+97afde1630/python/lsst/pipe/base/pipeline.py", line 135, in __init__
      		 
          self.connections = config.connections.ConnectionsClass(config=config)
      		 
        File "/j/ws/sqre/verify_drp_metrics/hsc-master^faro-master/run/jointcal/python/lsst/jointcal/jointcal.py", line 353, in __init__
      		 
          for key in list(self.outputs.keys()):
      		 
      AttributeError: 'set' object has no attribute 'keys'

      I only have the one jointcal gen3 test, so it didn't catch this. Probably best to switch the HSC tests over to gen3, so I can exercise this properly.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28863 Add metrics output and tests to gen3 jointcal

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Aside from improved testing, the fix I believe is simply to remove .keys() from https://github.com/lsst/jointcal/blob/fa6a221401145452d374643d700e47b6560cc8c1/python/lsst/jointcal/jointcal.py#L347 and https://github.com/lsst/jointcal/blob/fa6a221401145452d374643d700e47b6560cc8c1/python/lsst/jointcal/jointcal.py#L353

            Show
            erykoff Eli Rykoff added a comment - Aside from improved testing, the fix I believe is simply to remove .keys() from https://github.com/lsst/jointcal/blob/fa6a221401145452d374643d700e47b6560cc8c1/python/lsst/jointcal/jointcal.py#L347 and https://github.com/lsst/jointcal/blob/fa6a221401145452d374643d700e47b6560cc8c1/python/lsst/jointcal/jointcal.py#L353
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            PR is here: https://github.com/lsst/jointcal/pull/198
            Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35156/pipeline

            Show
            erykoff Eli Rykoff added a comment - PR is here: https://github.com/lsst/jointcal/pull/198 Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35156/pipeline
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Looks great. Thanks for the tests.

            Show
            krughoff Simon Krughoff added a comment - Looks great. Thanks for the tests.

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Simon Krughoff
              Watchers:
              Eli Rykoff, Ian Sullivan, John Parejko, Kian-Tat Lim, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.