Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32247

Import AUXTEL_LOCATION from obs_lsst instead of redefining (wrong)

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • atmospec, rapid_analysis
    • None
    • 0.25
    • Data Release Production
    • No

    Description

      Two packages have AUXTEL_LOCATION (re)defined (incorrectly). Import from obs_lsst where it's correct.

      Attachments

        Activity

          No builds found.
          mfisherlevine Merlin Fisher-Levine created issue -
          mfisherlevine Merlin Fisher-Levine made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          mfisherlevine Merlin Fisher-Levine made changes -
          Reviewers Christopher Waters [ cwaters ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          czw Christopher Waters made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          mfisherlevine Merlin Fisher-Levine made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Team Data Release Production [ 10301 ]
          tjenness Tim Jenness added a comment -

          I wasn't expecting AUXTEL_LOCATION to be a part of the public API but I guess I walked into this one by not using a leading underscore...

          tjenness Tim Jenness added a comment - I wasn't expecting AUXTEL_LOCATION to be a part of the public API but I guess I walked into this one by not using a leading underscore...

          I can copy and paste the instantiation rather than importing it if you prefer. That's what I was doing originally, I was just doing it wrong, and found the correct values there and thought I should import it instead of copying and pasting. Would that be better?

          mfisherlevine Merlin Fisher-Levine added a comment - I can copy and paste the instantiation rather than importing it if you prefer. That's what I was doing originally, I was just doing it wrong, and found the correct values there and thought I should import it instead of copying and pasting. Would that be better?
          tjenness Tim Jenness added a comment -

          if you need it it's obviously better to get it from obs_lsst. I was just thinking that I should have made it more explicitly public.

          tjenness Tim Jenness added a comment - if you need it it's obviously better to get it from obs_lsst. I was just thinking that I should have made it more explicitly public.

          Yeah, it is a bit hidden down in the translators. This is why (in the package you may not have seen because it's not in lsst_distrib and Frossie is steadfastly ignoring my requests to get it added to Jira ) I import it and manually re-export it via _all_, so it's easily found.

          mfisherlevine Merlin Fisher-Levine added a comment - Yeah, it is a bit hidden down in the translators. This is why (in the package you may not have seen because it's not in lsst_distrib and Frossie is steadfastly ignoring my requests to get it added to Jira ) I import it and manually re-export it via _ all _, so it's easily found.
          yusra Yusra AlSayyad made changes -
          Epic Link DM-30539 [ 511197 ]
          yusra Yusra AlSayyad made changes -
          Epic Link DM-30539 [ 511197 ] DM-30546 [ 511212 ]
          yusra Yusra AlSayyad made changes -
          Epic Link DM-30546 [ 511212 ] DM-30539 [ 511197 ]

          People

            mfisherlevine Merlin Fisher-Levine
            mfisherlevine Merlin Fisher-Levine
            Christopher Waters
            Christopher Waters, Merlin Fisher-Levine, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.