Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32250

Enable mypy checking in pipe_base and obs_base

    XMLWordPrintable

    Details

      Description

      This is one of a few implementation tickets for RFC-809; I'm starting it early as a place to put mypy configuration and typing fixes so I can use them locally as a temporary base for other tickets before the RFC is adopted.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I'm basically done with pipe_base and obs_base (with some changes upstream of them in resources and daf_butler), but I'm spinning off doing ctrl_mpexec onto another ticket (DM-33817) so I can return to other priorities.

            Show
            jbosch Jim Bosch added a comment - I'm basically done with pipe_base and obs_base (with some changes upstream of them in resources and daf_butler), but I'm spinning off doing ctrl_mpexec onto another ticket ( DM-33817 ) so I can return to other priorities.
            Hide
            jbosch Jim Bosch added a comment -

            Tim Jenness, could you review most of this?

            Most changes are trivial, and looking at commit messages should tell you which ones might not be.  The changes in RawIngestTask and the assemblers are the ones that were the most hairy.  It might make sense to look at obs_base and pipe_base first, and then daf_butler and resources, as it was the higher-level package typing that led to the need to update some of the annotations in the two lower-level packages.

            Nate Lust, could you look at the changes in the QuantumGraph subpackage in pipe_base?  They're confined to one commit that should be obvious (and if I linked via SHA1 it'd probably break due to rebasing at some point).

            PRs are:

            https://github.com/lsst/resources/pull/8

            https://github.com/lsst/daf_butler/pull/647

            https://github.com/lsst/pipe_base/pull/235

            https://github.com/lsst/obs_base/pull/408

            Codecov doesn't like most of these, but only very slightly.

            Show
            jbosch Jim Bosch added a comment - Tim Jenness , could you review most of this? Most changes are trivial, and looking at commit messages should tell you which ones might not be.  The changes in RawIngestTask and the assemblers are the ones that were the most hairy.  It might make sense to look at obs_base and pipe_base first, and then daf_butler and resources, as it was the higher-level package typing that led to the need to update some of the annotations in the two lower-level packages. Nate Lust , could you look at the changes in the QuantumGraph subpackage in pipe_base?  They're confined to one commit that should be obvious (and if I linked via SHA1 it'd probably break due to rebasing at some point). PRs are: https://github.com/lsst/resources/pull/8 https://github.com/lsst/daf_butler/pull/647 https://github.com/lsst/pipe_base/pull/235 https://github.com/lsst/obs_base/pull/408 Codecov doesn't like most of these, but only very slightly.
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me. I'll take myself off as reviewer.

            Show
            tjenness Tim Jenness added a comment - Looks good to me. I'll take myself off as reviewer.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.