Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32250

Enable mypy checking in pipe_base and obs_base

    XMLWordPrintable

    Details

      Description

      This is one of a few implementation tickets for RFC-809; I'm starting it early as a place to put mypy configuration and typing fixes so I can use them locally as a temporary base for other tickets before the RFC is adopted.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-809 Require black+isort formatting and mypy checking in middleware packages

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33817 Enable mypy checking in ctrl_mpexec

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-809 [ RFC-809 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30536 [ 511194 ] DM-30543 [ 511201 ]
            jbosch Jim Bosch made changes -
            Component/s obs_base [ 10719 ]
            jbosch Jim Bosch made changes -
            Summary Enable mypy checking in pipe_base and ctrl_mpexec Enable mypy checking in pipe_base, obs_base, and ctrl_mpexec
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm basically done with pipe_base and obs_base (with some changes upstream of them in resources and daf_butler), but I'm spinning off doing ctrl_mpexec onto another ticket (DM-33817) so I can return to other priorities.

            Show
            jbosch Jim Bosch added a comment - I'm basically done with pipe_base and obs_base (with some changes upstream of them in resources and daf_butler), but I'm spinning off doing ctrl_mpexec onto another ticket ( DM-33817 ) so I can return to other priorities.
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-33817 [ DM-33817 ]
            jbosch Jim Bosch made changes -
            Summary Enable mypy checking in pipe_base, obs_base, and ctrl_mpexec Enable mypy checking in pipe_base, obs_base, and ~ctrl_mpexec~
            jbosch Jim Bosch made changes -
            Summary Enable mypy checking in pipe_base, obs_base, and ~ctrl_mpexec~ Enable mypy checking in pipe_base and obs_base
            jbosch Jim Bosch made changes -
            Story Points 2 4
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Tim Jenness, could you review most of this?

            Most changes are trivial, and looking at commit messages should tell you which ones might not be.  The changes in RawIngestTask and the assemblers are the ones that were the most hairy.  It might make sense to look at obs_base and pipe_base first, and then daf_butler and resources, as it was the higher-level package typing that led to the need to update some of the annotations in the two lower-level packages.

            Nate Lust, could you look at the changes in the QuantumGraph subpackage in pipe_base?  They're confined to one commit that should be obvious (and if I linked via SHA1 it'd probably break due to rebasing at some point).

            PRs are:

            https://github.com/lsst/resources/pull/8

            https://github.com/lsst/daf_butler/pull/647

            https://github.com/lsst/pipe_base/pull/235

            https://github.com/lsst/obs_base/pull/408

            Codecov doesn't like most of these, but only very slightly.

            Show
            jbosch Jim Bosch added a comment - Tim Jenness , could you review most of this? Most changes are trivial, and looking at commit messages should tell you which ones might not be.  The changes in RawIngestTask and the assemblers are the ones that were the most hairy.  It might make sense to look at obs_base and pipe_base first, and then daf_butler and resources, as it was the higher-level package typing that led to the need to update some of the annotations in the two lower-level packages. Nate Lust , could you look at the changes in the QuantumGraph subpackage in pipe_base?  They're confined to one commit that should be obvious (and if I linked via SHA1 it'd probably break due to rebasing at some point). PRs are: https://github.com/lsst/resources/pull/8 https://github.com/lsst/daf_butler/pull/647 https://github.com/lsst/pipe_base/pull/235 https://github.com/lsst/obs_base/pull/408 Codecov doesn't like most of these, but only very slightly.
            jbosch Jim Bosch made changes -
            Reviewers Nate Lust, Tim Jenness [ nlust, tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good to me. I'll take myself off as reviewer.

            Show
            tjenness Tim Jenness added a comment - Looks good to me. I'll take myself off as reviewer.
            tjenness Tim Jenness made changes -
            Reviewers Nate Lust, Tim Jenness [ nlust, tjenness ] Nate Lust [ nlust ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30543 [ 511201 ] DM-30551 [ 511217 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.