Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32252

NoiseReplacer noiseSource='variance' is untested and broken.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      Erin Sheldon reports that the following snippet crashes:

      from lsst.afw.image import ExposureF, MaskedImageF
      from lsst.meas.base import NoiseReplacerConfig, NoiseReplacer
       
       
      mi = MaskedImageF(20, 10)
      mi.set((1, 0x0, 0.1))
      exposure = ExposureF(mi)
       
      config = NoiseReplacerConfig()
      config.noiseSource = 'variance'
      replacer = NoiseReplacer(
          config,
          exposure=exposure,
          footprints={},
      )
      

      This reports AttributeError: 'VariancePlaneNoiseGenerator' object has no attribute 'std'.

      The lines here https://github.com/lsst/meas_base/blob/61eb88f8e6ad679bbf4d7d3435e00684a9ab19a1/python/lsst/meas/base/noiseReplacer.py#L198-L200 seem to be the offenders.

      This ticket will add a simple test for config.noiseSource='variance' and make sure it works.

        Attachments

          Activity

          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          OK all done, minor comments on PR.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - OK all done, minor comments on PR.

            People

            Assignee:
            erykoff Eli Rykoff
            Reporter:
            erykoff Eli Rykoff
            Reviewers:
            Merlin Fisher-Levine
            Watchers:
            Eli Rykoff, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.