Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32266

Unify the Servers of DDS and GUI in Low-Level Rotator Controller

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jan 17 - Jan 31, TSSW Sprint - Jan 31 - Feb 14
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Unify the servers of DDS and GUI in low-level rotator controller (use the existed DDS servers as a main body because they allow the connection/disconnection). To work on this, I would need to figure out why the wrapper sometimes has the problem to get the updated values from the Copley drive. In addition, I need to check the possible memory leakage in the code.

      Note. In DM-32550, the code was updated to reject all connections to allow the rerun of wrapper code to remap the PDO of drive.

      Use the version of 1.4.0 for rotator controller.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32050 Refactor the Low-Level Rotator Controller to be the TCP/IP Server

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33252 Unify the Servers in Low-Level Common Code Repository in Phase 1

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33630 Test the Latest Version of Rotator Code on Summit

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33671 Rename the driverStatus to driveStatus in Low-Level Rotator Controller

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32550 Reject the Following Connection Request in Rotator Controller

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            I discussed with Russell for the use case to put the CSC to be the default commander. In the long run, we will modify the state machine in the Simulink model. At this moment, if there is the interlock/drive fault in the Offline/PublishOnly state, the CSC will not try to clear the error. Instead, it should be EUI to do so. But CSC should be still able to connect to the controller to get the telemetry. I need to consider how to support this in the another ticket to put the CSC to be the default commander.

            Show
            ttsai Te-Wei Tsai added a comment - - edited I discussed with Russell for the use case to put the CSC to be the default commander. In the long run, we will modify the state machine in the Simulink model. At this moment, if there is the interlock/drive fault in the Offline/PublishOnly state, the CSC will not try to clear the error. Instead, it should be EUI to do so. But CSC should be still able to connect to the controller to get the telemetry. I need to consider how to support this in the another ticket to put the CSC to be the default commander.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PRs:
            1. https://github.com/lsst-ts/ts_rotator_gui/pull/20
            2. https://github.com/lsst-ts/ts_rotator_controller/pull/32

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_rotator_gui/pull/20 2. https://github.com/lsst-ts/ts_rotator_controller/pull/32 Thanks!
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Reviewed on github. A wonderful update.

            Show
            rowen Russell Owen added a comment - Reviewed on github. A wonderful update.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.