Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32285

SDSS shape errors have yy and xy interchanged

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Due to a convention mismatch, the `_yyErr` and `_xyErr` components are interchanged for `base_SdssShape` plugin. This ticket fixes this bug and adds a MonteCarlo unit test that would have caught it in the first place.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          kannawad Arun Kannawadi created issue -
          kannawad Arun Kannawadi made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Ongoing Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35214/pipeline

          Show
          kannawad Arun Kannawadi added a comment - Ongoing Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35214/pipeline
          kannawad Arun Kannawadi made changes -
          Reviewers Joshua Meyers [ jmeyers314 ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          kannawad Arun Kannawadi made changes -
          Attachment image-2021-10-20-14-30-27-908.png [ 54279 ]
          kannawad Arun Kannawadi made changes -
          Attachment image-2021-10-20-14-30-52-010.png [ 54280 ]
          kannawad Arun Kannawadi made changes -
          Attachment image-2021-10-20-14-31-03-267.png [ 54281 ]
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Results from the MonteCarlo test presented visually. When normalized by the quoted uncertainties prior to the fix, the `_xy` and `_yy` moments do not appear to be distributed normally, but after the fix, they are:

           

          Show
          kannawad Arun Kannawadi added a comment - Results from the MonteCarlo test presented visually. When normalized by the quoted uncertainties prior to the fix, the `_xy` and `_yy` moments do not appear to be distributed normally, but after the fix, they are:  
          kannawad Arun Kannawadi made changes -
          Attachment image-2021-10-20-14-30-52-010.png [ 54280 ]
          Hide
          Permalink
          jmeyers314 Joshua Meyers added a comment -

          LGTM.  Minor comments on PR.

          Show
          jmeyers314 Joshua Meyers added a comment - LGTM.  Minor comments on PR.
          jmeyers314 Joshua Meyers made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          kannawad Arun Kannawadi made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Thanks for the review Josh! Comments addressed and the changes are part of w43.

          Show
          kannawad Arun Kannawadi added a comment - Thanks for the review Josh! Comments addressed and the changes are part of w43.
          yusra Yusra AlSayyad made changes -
          Epic Link DM-31857 [ 723839 ] DM-30542 [ 511200 ]

            People

            Assignee:
            kannawad Arun Kannawadi
            Reporter:
            kannawad Arun Kannawadi
            Reviewers:
            Joshua Meyers
            Watchers:
            Arun Kannawadi, Joshua Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.