Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32300

Simplify `_build_distances_and_angles` to only use numpy arrays

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP F21-5 (October), AP F21-6 (November)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      _build_distances_and_angles was written using lists and concatenation vs creating an empty array ahead of time and filling it. The list method adds extra memory overhead and time. This was originally done for readability when there were more array's being filled.

        Attachments

          Activity

          Hide
          cmorrison Chris Morrison [X] (Inactive) added a comment - - edited

          Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35225/pipeline

          Code passes CI but fails ci_hsc for an unrelated reason. I'll run a few integration tests of the change just to make sure things are running as expected.

          Show
          cmorrison Chris Morrison [X] (Inactive) added a comment - - edited Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35225/pipeline Code passes CI but fails ci_hsc for an unrelated reason. I'll run a few integration tests of the change just to make sure things are running as expected.
          Hide
          cmorrison Chris Morrison [X] (Inactive) added a comment -

          Completed a run through of ~40k detectors from RC2. The timing improvement is small but noticeable.

          Weekly w_2021_43:
          Mean: 3.341 STD: 4.154
          Percentiles:   5%,  25%,   50%,  75%,     95%
                              1.100, 1.460, 2.012, 3.470, 10.577
          Min: 0.707 Max: 184.726

          This Ticket:
          Mean: 3.245 STD: 4.039
          Percentiles:   5%,  25%,  50%,   75%,    95%
                              1.071, 1.414, 1.934, 3.367, 10.305
          Min: 0.693 Max: 180.041

          Show
          cmorrison Chris Morrison [X] (Inactive) added a comment - Completed a run through of ~40k detectors from RC2. The timing improvement is small but noticeable. Weekly w_2021_43: Mean: 3.341 STD: 4.154 Percentiles:   5%,  25%,   50%,  75%,     95%                     1.100, 1.460, 2.012, 3.470, 10.577 Min: 0.707 Max: 184.726 This Ticket: Mean: 3.245 STD: 4.039 Percentiles:   5%,  25%,  50%,   75%,    95%                     1.071, 1.414, 1.934, 3.367, 10.305 Min: 0.693 Max: 180.041
          Show
          cmorrison Chris Morrison [X] (Inactive) added a comment - Jenkins after review with ci_hsc_gen3: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35340/pipeline

            People

            Assignee:
            cmorrison Chris Morrison [X] (Inactive)
            Reporter:
            cmorrison Chris Morrison [X] (Inactive)
            Reviewers:
            Kenneth Herner
            Watchers:
            Chris Morrison [X] (Inactive), Eric Bellm, Ian Sullivan, Kenneth Herner
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.