[DM-32306] refBand functor doesn't know that u-band exists - Jira

XML

Word

Printable

Details

Type: Bug
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: None
Labels:

Story Points:
1
Epic Link:
f21b-a&p-preops
Team:
Data Release Production
Urgent?:
No

Description

The referenceBand functor that returns which band was the reference band doesn't know that u-band exists. As a result, if the reference-band is in fact 'u', it returns the wrong answer: 'i'.

Attachments

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Yusra AlSayyad added a comment - 26/Oct/21 1:10 AM - edited

Hey Dan, do you have time to review this fix to the problem you found last week?

I added a second commit, which was inspired by ~~DM-32238~~, where I noticed I needed to be more careful when there are no rows.

Would like to get in for Wednesday's weekly.
Jenkins going at https://ci.lsst.codes/job/stack-os-matrix/35248/display/redirect

Show

Yusra AlSayyad added a comment - 26/Oct/21 1:10 AM - edited Hey Dan, do you have time to review this fix to the problem you found last week? I added a second commit, which was inspired by DM-32238 , where I noticed I needed to be more careful when there are no rows. Would like to get in for Wednesday's weekly. Jenkins going at https://ci.lsst.codes/job/stack-os-matrix/35248/display/redirect

Hide

Permalink

Dan Taranu added a comment - 26/Oct/21 4:12 PM

Seems fine. I had optional suggestions. Looks like you need a rebase anyway.

Show

Dan Taranu added a comment - 26/Oct/21 4:12 PM Seems fine. I had optional suggestions. Looks like you need a rebase anyway.

People

Assignee:: Yusra AlSayyad

Reporter:: Yusra AlSayyad

Reviewers:: Dan Taranu

Watchers:: Dan Taranu, Yusra AlSayyad

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 22/Oct/21 3:39 AM

Updated:: 29/Oct/21 3:39 AM

Resolved:: 28/Oct/21 1:26 AM

Jenkins

No builds found.

Data Management