Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32324

Add forced source table to sdm_schemas and ci_imsim

    XMLWordPrintable

    Details

    • Team:
      DM Science
    • Urgent?:
      No

      Description

      Add forced source table schema to sdm_schemas dp02_dc2.yaml

        Attachments

          Activity

          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          I see. I missed to consider that this ticket branch doesn't have to be fully backported to v23.

          Thinking more about ci_imsim runs, I'd prefer not to have a separate dp02_dc2.yaml for now, because it wouldn't be checked in ci_imsim and the two yml will easily diverge. Confirming with Fritz Mueller it's true that the schema browser uses one single branch, and also I'm not sure if the TAP related tools can use v23.0.x:yml/imsim.yml. But I think it's probably better to make that copy of dp02_dc2.yaml when we are closer to done in releasing v23.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - I see. I missed to consider that this ticket branch doesn't have to be fully backported to v23. Thinking more about ci_imsim runs, I'd prefer not to have a separate dp02_dc2.yaml for now, because it wouldn't be checked in ci_imsim and the two yml will easily diverge. Confirming with Fritz Mueller it's true that the schema browser uses one single branch, and also I'm not sure if the TAP related tools can use v23.0.x:yml/imsim.yml . But I think it's probably better to make that copy of dp02_dc2.yaml when we are closer to done in releasing v23.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          In sdm_schemas, the build from GitHub Action Workflow fails currently, due to a bug in felis : DM-32599

          I'm gonna ignore that until DM-32599 is merged.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - In sdm_schemas, the build from GitHub Action Workflow fails currently, due to a bug in felis : DM-32599 I'm gonna ignore that until DM-32599 is merged.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          The ticket branch has been merged to master. There is no longer dp02_dc2.yaml , and ci_imsim uses imsim.yml now.

          Next to backport to v23.0.x. The v23.0.x:yml/imsim.yml will be different from master:yml/imsim.yml Either can be tested by running ci_imsim.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - The ticket branch has been merged to master. There is no longer dp02_dc2.yaml , and ci_imsim uses imsim.yml now. Next to backport to v23.0.x. The v23.0.x:yml/imsim.yml will be different from master:yml/imsim.yml Either can be tested by running ci_imsim.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Backported to v23

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Backported to v23
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          I'm a little concerned that ci_imsim might be special and it might not get tagged as intended in rc4. The top of v23.0.x and master now have different SHA, which makes sense in v23/release/backport. We will want rc4 tagged in v23.0.x, not master, but I have doubts how ci_imsim is getting tagged (maybe I'm just being paranoid..) Will see what happens when rc4 is done...

          Show
          hchiang2 Hsin-Fang Chiang added a comment - I'm a little concerned that ci_imsim might be special and it might not get tagged as intended in rc4. The top of v23.0.x and master now have different SHA, which makes sense in v23/release/backport. We will want rc4 tagged in v23.0.x, not master, but I have doubts how ci_imsim is getting tagged (maybe I'm just being paranoid..) Will see what happens when rc4 is done...

            People

            Assignee:
            hchiang2 Hsin-Fang Chiang
            Reporter:
            hchiang2 Hsin-Fang Chiang
            Reviewers:
            Yusra AlSayyad
            Watchers:
            Colin Slater, Hsin-Fang Chiang, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.