Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:4
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
Create a new package for cell-based coadds, starting with:
- Data structures for representing those coadds and providing Exposure views into one or more cells.
- A piecewise Psf subclass suitable for representing the PSF of these coadds (this is why the package will have C++).
- A PipelineTask (to be migrated from a DESC repository) and builds these coadds, given a pluggable subtask that does the real work.
In the future, it may also have a Kaiser coadd implementation.
Attachments
Activity
Commit(s) to cherry-pick are in DM-32412 branch in the repo and begin with `cherry-pick:`
I've done the cherry picks and added a unit test for UniformGrid. I'm going to put off the rest of the testing for another ticket, as it'll be a fair amount of work to mock up data to drive tests of anything involving ImagePlane (not a ton of work - I just don't want this ticket to be blocking you anymore).
Thanks Jim. I'm off today, but will look at the first thing on Monday.
This is looking great! I couldn't find anything obviously wrong, but if there are changes needed as I build on these, we should be able to do them in another ticket.
Arun Kannawadi, I think it's time to call this In Review. I'm happy to still add that commit from your branch with the classmethods in _identifiers.py that we discussed, and I might add a few more unit tests before you're done if I get a chance. But this now has all of the CI stuff ready to go, and I figure it'll be good to let you rebase on it and start cleaning up your branch to satisfy CI while you review (check out the updated README on the branch for instructions).
It definitely needs more tests, and I want to get FITS persistence in quickly, but for those most part I think it makes sense to do that on new tickets so I can get out of your way.
PR is here: https://github.com/lsst-dm/cell_coadds/pull/1