Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32396

SdssCentroid gives up close to edges

    XMLWordPrintable

    Details

      Description

      Erin Sheldon reports that SdssCentroid doesn't try very hard close to the edge of an image, just giving up when it's within about a PSF width.  That's not unreasonable, given that it uses the PSF model, but we could probably have a better fallback than giving up entirely (with a quality flag, of course).

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37612 Remove unit tests of deprecated code

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            jbosch Jim Bosch created issue -
            yusra Yusra AlSayyad made changes -
            Field Original Value New Value
            Epic Link DM-30536 [ 511194 ] DM-30543 [ 511201 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30543 [ 511201 ] DM-30551 [ 511217 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-30551 [ 511217 ] DM-32153 [ 779823 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-32153 [ 779823 ] DM-32161 [ 779857 ]
            Hide
            Permalink
            erfan Erfan Nourbakhsh added a comment - - edited

            The idea is to replace the PSF with a tiny Gaussian (e.g. 5 pixels for the width of the PSF image, sigma = 0.5 pixels) if the EDGE flag is set on the first try. We also need to make sure we don't bin after that. So we need to consider adding logic to stop binning early.

            On GitHub: https://github.com/lsst/meas_base

            Starting point:
            https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L439

            https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L367

            https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L440

            Show
            erfan Erfan Nourbakhsh added a comment - - edited The idea is to replace the PSF with a tiny Gaussian (e.g. 5 pixels for the width of the PSF image, sigma = 0.5 pixels) if the EDGE flag is set on the first try. We also need to make sure we don't bin after that. So we need to consider adding logic to stop binning early. On GitHub: https://github.com/lsst/meas_base Starting point: https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L439 https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L367 https://github.com/lsst/meas_base/blob/be2ba2026d79ec89733cf9f2d962b29926d2ae8a/src/SdssCentroid.cc#L440
            erfan Erfan Nourbakhsh made changes -
            Assignee Jim Bosch [ jbosch ] Erfan Nourbakhsh [ JIRAUSER20413 ]
            erfan Erfan Nourbakhsh made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-32161 [ 779857 ] DM-32168 [ 779882 ]
            sullivan Ian Sullivan made changes -
            Link This issue relates to DM-37612 [ DM-37612 ]
            Hide
            Permalink
            erfan Erfan Nourbakhsh added a comment -

            Jenkins is green: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37940/pipeline/

            Show
            erfan Erfan Nourbakhsh added a comment - Jenkins is green:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37940/pipeline/
            Hide
            Permalink
            erfan Erfan Nourbakhsh added a comment -

            Jenkins run was successful. Your review will be appreciated.

            Show
            erfan Erfan Nourbakhsh added a comment - Jenkins run was successful. Your review will be appreciated.
            erfan Erfan Nourbakhsh made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good to me, no new comments.

            Show
            jbosch Jim Bosch added a comment - Looks good to me, no new comments.
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            erfan Erfan Nourbakhsh made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            yusra Yusra AlSayyad made changes -
            Story Points 4

              People

              Assignee:
              erfan Erfan Nourbakhsh
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Erfan Nourbakhsh, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.