Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32404

Fix incorrect use of pytest in two packages

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      When I initially modernized my unit tests I misunderstood pytest.approx. Fix incorrect usage in ts_utils and ts_watcher. (A global search did not turn up any other packages with this issue).

        Attachments

          Issue Links

          mitigates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32377 Fix intermittent Watcher unit test failure

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I also:

            • Fixed DM-32377 by adding some time slop to the ts_watcher unit tests, to compensate for clock jitter in macOS Docker (and possible very slight clock jitter in Jenkins).
            • Modernized the new Watcher Jenkinsfile to make it look like the template. I did not update the version history for this (nor for the pytest.approx misuse) because I haven't yet released a watcher version with modernized tests and a Jenkinsfile.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I also: Fixed DM-32377 by adding some time slop to the ts_watcher unit tests, to compensate for clock jitter in macOS Docker (and possible very slight clock jitter in Jenkins). Modernized the new Watcher Jenkinsfile to make it look like the template. I did not update the version history for this (nor for the pytest.approx misuse) because I haven't yet released a watcher version with modernized tests and a Jenkinsfile. Pull requests: https://github.com/lsst-ts/ts_utils/pull/2 https://github.com/lsst-ts/ts_watcher/pull/39
            Hide
            Permalink
            ecoughlin Eric Coughlin added a comment -

            Reviewed in GitHub.

            Show
            ecoughlin Eric Coughlin added a comment - Reviewed in GitHub.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Released ts_utils v1.0.1

            Merged ts_watcher to develop; release is pending

            Show
            rowen Russell Owen added a comment - Released ts_utils v1.0.1 Merged ts_watcher to develop; release is pending

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.