Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32411

Change where translations are handled in WarpedPsf/CoaddPsf

    XMLWordPrintable

    Details

    • Story Points:
      6
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Erin Sheldon and Matt Becker have long reported that DM's CoaddPsf is not as accurate as it could be, in that they get significantly better agreement between the coadded image and PSF by rendering the input PSF at integer coadd positions (and hence fractional input-image positions) and then warping with the fractional translation included.

      A conversation at the DESC Sprint Week of 2021-10-25 helped us at least mostly wrap our heads around the problem; we had not taken action on this problem because it wasn't clear which of our assumptions about Nyquist sampling and Lanczos were breaking down, and hence whether simply adopting their approach would address our more general problem of needing to provide coadd PSFs at arbitrary (i.e. not just integer) pixel positions. The short answer is it looks like it should - even if their approach still isn't quite right, it's more right than what we're doing, and we should modify CoaddPsf and WarpedPsf to operate the same way.

      This won't actually affect the metadetect development effort, because we don't plan to use CoaddPsf or WarpedPsf for cell-based coadds anyway, but it still seems worth doing before any major production run that does not use cell-based coadds for all measurements.

      As part of this ticket, we should also actually do the math to try to get an even more complete understanding of what's going on. I'm thinking specifically of writing down both approaches and Fourier transforming them, applying the Poisson summation formula as needed, without assuming that the warping kernel is Sinc or even well-sampled. I'm particularly curious whether this observed discrepancy tells us anything about how much we should expect coadd noise to be correlated, and whether we can pin the problem squarely on differences between Lanczos and sinc either inside or outside the band limit.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Ah, thanks for the Jenkins run. I just kicked off one now (which I've just canceled), and you thinking about it a bit earlier might help me get to bed a bit earlier tonight.

            PSF flux changes are indeed not surprising but still a bit concerning; it hadn't occurred to me that this would change the PSF on the coadds without changing the aperture correction (since that's coadded separately, and has no way to take into account issues like this at all). I think it's got to either be something we won't notice or an improvement, but an improvement that upsets the carefully-tuned extendedness balance could still be a problem. I still think we should merge; this is the kind of subtle thing we really need a full RC2 run to test anyway.

            Show
            jbosch Jim Bosch added a comment - Ah, thanks for the Jenkins run. I just kicked off one now (which I've just canceled), and you thinking about it a bit earlier might help me get to bed a bit earlier tonight. PSF flux changes are indeed not surprising but still a bit concerning; it hadn't occurred to me that this would change the PSF on the coadds without changing the aperture correction (since that's coadded separately, and has no way to take into account issues like this at all). I think it's got to either be something we won't notice or an improvement, but an improvement that upsets the carefully-tuned extendedness balance could still be a problem. I still think we should merge; this is the kind of subtle thing we really need a full RC2 run to test anyway.
            Hide
            jbosch Jim Bosch added a comment -

            I created DM-34966 for the follow-up math work. Joshua Meyers, are you ready to hit the Reviewed button (or did you just forget to earlier)?

            Show
            jbosch Jim Bosch added a comment - I created DM-34966 for the follow-up math work. Joshua Meyers , are you ready to hit the Reviewed button (or did you just forget to earlier)?
            Hide
            kannawad Arun Kannawadi added a comment -

            I wasn't sure initially if `pipelines_check` would build against this ticket or if it would interfere with the changes in DM-34778. But looks like the tests in `pipeines_check` are only on single-visit images, so I don't expect a problem there. 

            Show
            kannawad Arun Kannawadi added a comment - I wasn't sure initially if `pipelines_check` would build against this ticket or if it would interfere with the changes in DM-34778 . But looks like the tests in `pipeines_check` are only on single-visit images, so I don't expect a problem there. 
            Hide
            kannawad Arun Kannawadi added a comment -

            Jenkins passed!

            Show
            kannawad Arun Kannawadi added a comment - Jenkins passed!
            Hide
            yusra Yusra AlSayyad added a comment -

            Moving to the object characterization epic which is where we put tickets towards shear estimation.

            Show
            yusra Yusra AlSayyad added a comment - Moving to the object characterization epic which is where we put tickets towards shear estimation.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Joshua Meyers
              Watchers:
              Arun Kannawadi, Jim Bosch, Joshua Meyers, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.