# pipe_tasks test_processCcd PSF shape changes with eigen 3.4.0

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Urgent?:
No

#### Description

With eigen 3.4.0 installed in the conda environment, the pipe_tasks test_processCcd test fails with an assertion about psfIxx:

 AssertionError: 2.8433291863214247 != 2.843329671276296 within 7 places (4.849548713714569e-07 difference) : psfIxx 

This occurs whether jointcal and kht (which should not be used in this test) are built with eigen 3.3.7 or 3.4.0.

Is the test too strict, or is something else wrong?

#### Activity

Hide
Matthias Wittgen added a comment - - edited

Already approved in github by Tim Jenness , formally assigned this ticket for review as well.

Show
Matthias Wittgen added a comment - - edited Already approved in github by Tim Jenness , formally assigned this ticket for review as well.
Hide
Tim Jenness added a comment -

Looks fine to me. Please create a new ticket for doing the rubin-env change and make sure this ticket is blocked by that ticket.

I'm fine with you merging eups eigen 3.4.0 as part of this ticket.

Show
Tim Jenness added a comment - Looks fine to me. Please create a new ticket for doing the rubin-env change and make sure this ticket is blocked by that ticket. I'm fine with you merging eups eigen 3.4.0 as part of this ticket.
Hide
Matthias Wittgen added a comment - - edited

Eigen 3.4.0 will be updated  by  merging DM-34454 and not as part of this ticket. I am reluctant to overload this ticket as  DM-34454 can be tested independently without implementing DM-34453.

Remaining question is with DM-34454 should be merged after passing CI as this would result in having Eigen 3.3.9 conda stack and 3.4.0 EUPS. But we had a version mismatch before and it didn't seem to matter.

Show
Matthias Wittgen added a comment - - edited Eigen 3.4.0 will be updated  by  merging DM-34454 and not as part of this ticket. I am reluctant to overload this ticket as  DM-34454 can be tested independently without implementing DM-34453 . Remaining question is with DM-34454 should be merged after passing CI as this would result in having Eigen 3.3.9 conda stack and 3.4.0 EUPS. But we had a version mismatch before and it didn't seem to matter.
Hide
Eli Rykoff added a comment -

Yes, the eups and conda eigen are kept completely separate, so it's not a problem to have both at the same or different versions.

Show
Eli Rykoff added a comment - Yes, the eups and conda eigen are kept completely separate, so it's not a problem to have both at the same or different versions.
Hide
Matthias Wittgen added a comment -
Show
Matthias Wittgen added a comment - This could be merged to retire building Eigen, passes pipelines https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36944/pipeline/

#### People

Assignee:
Matthias Wittgen
Reporter:
Kian-Tat Lim
Reviewers:
Tim Jenness
Watchers:
Eli Rykoff, Joshua Meyers, Kian-Tat Lim, Matthias Wittgen, Tim Jenness, Yusra AlSayyad