Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32456

pipe_tasks test_processCcd PSF shape changes with eigen 3.4.0

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      With eigen 3.4.0 installed in the conda environment, the pipe_tasks test_processCcd test fails with an assertion about psfIxx:

      AssertionError: 2.8433291863214247 != 2.843329671276296 within 7 places (4.849548713714569e-07 difference) : psfIxx

      This occurs whether jointcal and kht (which should not be used in this test) are built with eigen 3.3.7 or 3.4.0.

      Is the test too strict, or is something else wrong?

        Attachments

          Issue Links

          duplicates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33496 Fix unit tests for linux-aarch64

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34453 Create rubinenv with eigen 3.4.0

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34454 Update EUPS Eigen to 3.4.0

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33073 Update Eigen to 3.3.9

          • Done

            Activity

            Ascending order - Click to sort in descending order
            13 older comments
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment - - edited

            Already approved in github by Tim Jenness , formally assigned this ticket for review as well.

            Show
            wittgen Matthias Wittgen added a comment - - edited Already approved in github by Tim Jenness , formally assigned this ticket for review as well.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks fine to me. Please create a new ticket for doing the rubin-env change and make sure this ticket is blocked by that ticket.

            I'm fine with you merging eups eigen 3.4.0 as part of this ticket.

            Show
            tjenness Tim Jenness added a comment - Looks fine to me. Please create a new ticket for doing the rubin-env change and make sure this ticket is blocked by that ticket. I'm fine with you merging eups eigen 3.4.0 as part of this ticket.
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment - - edited

            Eigen 3.4.0 will be updated  by  merging DM-34454 and not as part of this ticket. I am reluctant to overload this ticket as  DM-34454 can be tested independently without implementing DM-34453.

            Remaining question is with DM-34454 should be merged after passing CI as this would result in having Eigen 3.3.9 conda stack and 3.4.0 EUPS. But we had a version mismatch before and it didn't seem to matter.

            Show
            wittgen Matthias Wittgen added a comment - - edited Eigen 3.4.0 will be updated  by  merging DM-34454 and not as part of this ticket. I am reluctant to overload this ticket as  DM-34454 can be tested independently without implementing DM-34453 . Remaining question is with DM-34454 should be merged after passing CI as this would result in having Eigen 3.3.9 conda stack and 3.4.0 EUPS. But we had a version mismatch before and it didn't seem to matter.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Yes, the eups and conda eigen are kept completely separate, so it's not a problem to have both at the same or different versions.

            Show
            erykoff Eli Rykoff added a comment - Yes, the eups and conda eigen are kept completely separate, so it's not a problem to have both at the same or different versions.
            Hide
            Permalink
            wittgen Matthias Wittgen added a comment -

            This could be merged to retire building Eigen, passes pipelines
            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36944/pipeline/

            Show
            wittgen Matthias Wittgen added a comment - This could be merged to retire building Eigen, passes pipelines https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36944/pipeline/

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              ktl Kian-Tat Lim
              Reviewers:
              Tim Jenness
              Watchers:
              Eli Rykoff, Joshua Meyers, Kian-Tat Lim, Matthias Wittgen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.