Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Story Points:1
-
Epic Link:
-
Sprint:TSSW Sprint - Nov 08 - Nov 22
-
Team:Telescope and Site
-
Urgent?:No
Description
Please add location data to the ESS configurations in ts_config_ocs.
This would really help me with Watcher rules for two reasons:
- It helps the Operators understand an alarm
- It helps me pick the right data to use for the rules
It's not high priority, but definitely a "nice to have". And it may reduce the # of questions I ask you about the locations of sensors.
Attachments
Issue Links
- duplicates
-
- Won't Fix
Activity
Reviewed on github. Overall this looks great. My one substantive concern is that I think location strings that describe multiple sensors should be comma-separated according to the description in ts_xml. If you prefer commas then I need to update the watcher (simple) and it'd be nice to get ts_xml updated.
It took a bit longer to implement than expected since all ESS projects needed to start supporting location. I also was notified of a wrong baudrate value for the serial and FTDI devices in ts_ess_controller so I fixed that as well.
ts_ess_common PR:
https://github.com/lsst-ts/ts_ess_common/pull/8
ts_ess_controller PR:
https://github.com/lsst-ts/ts_ess_controller/pull/19
ts_ess_csc PR:
https://github.com/lsst-ts/ts_ess_csc/pull/49
ts_config_ocs PR:
https://github.com/lsst-ts/ts_config_ocs/pull/43