Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32549

Add position to psf.getDeterminantRadius() calls

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim, pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP F21-6 (November), AP S22-1 (December)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Calling psf.computeShape().getDeterminantRadius() without a position is deprecated, but is still present in several places in pipe_tasks. In those instances where no position is given, we should use the center of the current ccd or bbox, as appropriate.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31777 Determine and use correct position for PSF shape determination in ImageDifferenceTask

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            The offending code in imageDifference.py is being fixed in DM-31777

            Show
            sullivan Ian Sullivan added a comment - The offending code in imageDifference.py is being fixed in DM-31777
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            This is a pretty simple change, that fixes a whole bunch of deprecation warnings that you get when running any flavor of AssembleCoaddTask. I included the changes in ip_diffim because I see those warnings a lot, though there are additional packages that also raise some warnings. In the spirit of limiting scope creep and getting this done quickly, I've left this at two packages for now, but if you want I could try to be more comprehensive.

            Show
            sullivan Ian Sullivan added a comment - This is a pretty simple change, that fixes a whole bunch of deprecation warnings that you get when running any flavor of AssembleCoaddTask . I included the changes in ip_diffim because I see those warnings a lot, though there are additional packages that also raise some warnings. In the spirit of limiting scope creep and getting this done quickly, I've left this at two packages for now, but if you want I could try to be more comprehensive.
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Looks fine, good to fix this. While I've never used it before, as best I can tell, `getAveragePosition` is a PSF C++ flavored method in meas_algorithms, and should always be valid when fed to computeImage (and, presumably, computeShape).

            Can you please make a ticket to fix any remaining instances if you're not up for doing it on this ticket?

            Show
            mrawls Meredith Rawls added a comment - Looks fine, good to fix this. While I've never used it before, as best I can tell, `getAveragePosition` is a PSF C++ flavored method in meas_algorithms, and should always be valid when fed to computeImage (and, presumably, computeShape). Can you please make a ticket to fix any remaining instances if you're not up for doing it on this ticket?

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Meredith Rawls
              Watchers:
              Ian Sullivan, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.