Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:TSSW Sprint - Jan 03 - Jan 17
-
Team:Telescope and Site
-
Urgent?:No
Description
Allow the controller to be able to reject all the following connection request. By doing this, once there are no connections from TCP/IP clients anymore, the controller software will execute to end. The wrapper service in PXI controller will rerun the control software. The benefit of this is to clean all the drive related information contains the faults.
This task will need to update the EUI and controller code.
Attachments
Issue Links
Activity
After the discussion with Russell, we agreed to change the implementation to disconnect the CSC connection directly.
The GUI will prompt a new window to confirm the reboot of controller:
Please see the update of PR. Thanks!
Reviewed on github. Looks very nice. I'm impressed with how simple you were able to make it.
Since I will unify the code of GUI and DDS (which means both of them allow the multiple connections), the reboot is fine to me if the CSC user does not care about the CSC will enter the Fault state after the EUI user decides to reboot the system. To be honest, I think the main arguments here is the design logic instead of the risks in the above comments.