Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3258

CoaddPsf.getAveragePosition() is not a valid position

    XMLWordPrintable

    Details

      Description

      This is a port of HSC-1138 to LSST. That is an aggregate of two related minor fixes:

      • CoaddInputRecorder should default to saveVisitGoodPix=True so that average positions in the CoaddPsf can be properly weighted;
      • computeAveragePosition and doComputeKernelImage should be consistent about the data included when determining whether a source is off image.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2980 refactor coaddition code

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3243 Include polygon bounds in CoaddPsf logic

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-3387 Make use of good pixel count when building CoaddPsfs

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Russell – this contains a fix for a bug which was introduced in DM-3243 which is already assigned to you for review. I should have been more careful and included this fix in that ticket. Although it's too late for that now, I think it makes sense to consider them together, so would you mind looking at this too? It's only a couple of lines. Changes are on:

            Note that in the case of meas_algorithms it only makes sense to apply this on top of the fix for DM-3243 – the link above is to a diff relative to that branch rather than to master.

            Show
            swinbank John Swinbank added a comment - - edited Russell – this contains a fix for a bug which was introduced in DM-3243 which is already assigned to you for review. I should have been more careful and included this fix in that ticket. Although it's too late for that now, I think it makes sense to consider them together, so would you mind looking at this too? It's only a couple of lines. Changes are on: tickets/DM-3258 on meas_algorithms and tickets/DM-3258 on pipe_tasks . Note that in the case of meas_algorithms it only makes sense to apply this on top of the fix for DM-3243 – the link above is to a diff relative to that branch rather than to master .
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This looks great.

            Show
            rowen Russell Owen added a comment - This looks great.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks. Merged.

            Show
            swinbank John Swinbank added a comment - Thanks. Merged.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.