Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32594

Remove dependency on inflection in bps_config

    XMLWordPrintable

    Details

      Description

      Kian-Tat Lim pointed out that inflection was included by moto, but it no longer is (https://github.com/conda-forge/moto-feedstock/commit/8df708bc37c0a0bcf865d04c4a71ccc94fabea12#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9a). This breaks bps_config.py (https://github.com/lsst/ctrl_bps/blob/master/python/lsst/ctrl/bps/bps_config.py#L35).

       

      Besides being a very temporary workaround that doesn't work for all situations, the above has brought up bigger discussions about what should actually be supported in the config.  So, going to roll back the BPS config changes that checked various casing (snake case vs camel case vs lower case...) to requiring the keys used in submit yaml to exactly match those expected by bps or being used as variables in other submit values.  Whether to make the submit yaml more flexible will be postponed to the larger bps config rewrite ticket (DM-31245)

       

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32591 Use of inflection in ctrl_bps breaks with new moto version

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31245 rewrite BpsConfig

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mgower Michelle Gower added a comment -

            Rolled back changes.  Whether to make BpsConfig more flexible in key lookup is postponed until general rewrite in another ticket.

            Show
            mgower Michelle Gower added a comment - Rolled back changes.  Whether to make BpsConfig more flexible in key lookup is postponed until general rewrite in another ticket.
            Hide
            Permalink
            mgower Michelle Gower added a comment -

            Sergey Padolski  I looked around in the PanDA idf config and plugin.  There's a "runner_command" in both.  As far as I can tell without testing this should still work, but does not match the casing style of all the other config values.  Do you want me to change it in this ticket to runnerCommand or leave it for you to maybe change in a different PanDA specific ticket?

            Show
            mgower Michelle Gower added a comment - Sergey Padolski   I looked around in the PanDA idf config and plugin.  There's a "runner_command" in both.  As far as I can tell without testing this should still work, but does not match the casing style of all the other config values.  Do you want me to change it in this ticket to runnerCommand or leave it for you to maybe change in a different PanDA specific ticket?
            Hide
            Permalink
            mkowalik Mikolaj Kowalik added a comment -

            Looks good to me.

            Show
            mkowalik Mikolaj Kowalik added a comment - Looks good to me.
            Hide
            Permalink
            podolsky Sergey Padolski added a comment -

            thanks Michelle Gower, it will be nice it you could replace "runner_command" to match the style.

            Show
            podolsky Sergey Padolski added a comment - thanks Michelle Gower , it will be nice it you could replace "runner_command" to match the style.
            Hide
            Permalink
            mgower Michelle Gower added a comment -

            I found a few other and changed them too.  I pushed the changes.  Let me know how it looks and if I can merge it.

            Show
            mgower Michelle Gower added a comment - I found a few other and changed them too.  I pushed the changes.  Let me know how it looks and if I can merge it.
            Hide
            Permalink
            podolsky Sergey Padolski added a comment -

            The test was successfully submitted and the first task has finished. Fine with me to merge.

            Show
            podolsky Sergey Padolski added a comment - The test was successfully submitted and the first task has finished. Fine with me to merge.

              People

              Assignee:
              mgower Michelle Gower
              Reporter:
              mgower Michelle Gower
              Reviewers:
              Mikolaj Kowalik
              Watchers:
              Michelle Gower, Mikolaj Kowalik, Quentin Le Boulc'h, Sergey Padolski
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.