[DM-3259] Define polygon bounds for CCDs based on vignetted regions - Jira

John Swinbank created issue - 29/Jul/15 8:38 AM

John Swinbank made changes - 29/Jul/15 8:38 AM

Field	Original Value	New Value
Epic Link		~~DM-1942~~ [ 16008 ]

John Swinbank made changes - 29/Jul/15 8:38 AM

Link

This issue relates to ~~DM-2981~~ [ ~~DM-2981~~ ]

John Swinbank made changes - 29/Jul/15 8:38 AM

Story Points

1

Jim Bosch made changes - 02/Aug/15 4:12 PM

Rank

Ranked higher

John Swinbank made changes - 26/Aug/15 8:38 AM

Epic Link

~~DM-1942~~ [ 16008 ]

~~DM-3560~~ [ 19650 ]

John Swinbank made changes - 26/Aug/15 10:00 AM

Epic Link

~~DM-3560~~ [ 19650 ]

~~DM-3568~~ [ 19662 ]

Lauren MacArthur made changes - 03/Nov/15 9:29 AM

Assignee

Lauren MacArthur [ lauren ]

Lauren MacArthur made changes - 03/Nov/15 9:29 AM

Sprint

Science Pipelines DM-W16-3 [ 182 ]

Lauren MacArthur made changes - 03/Nov/15 9:29 AM

Status

To Do [ 10001 ]

In Progress [ 3 ]

Hide

Permalink

Lauren MacArthur added a comment - 03/Nov/15 10:16 AM

The pipe_tasks commit Add polygon to tempExp files. was done on ~~DM-2981~~ (commit).

Show

Lauren MacArthur added a comment - 03/Nov/15 10:16 AM The pipe_tasks commit Add polygon to tempExp files. was done on DM-2981 ( commit ).

Hide

Permalink

Lauren MacArthur added a comment - 04/Nov/15 4:04 PM

Bob, would you mind giving this a review? As noted in the commit message, the behavior is slightly different than HSC's as the getCorners() function returns the coord of the corner of the pixels (i.e. widened by half a pixel), so instead of the lower-left-corner being (0,0) it would be (-0.5,-0.5). Similarly, a upper-right-corner of (N,M) would now be (N+0.5,M+0.5). I believe this is the desired behavior here.

I ran this for ccd=22 (an edge ccd) on both stacks:

On HSC:

validPolygon =  Polygon([Point2D(5.022926519e-13, 909.8878363), Point2D(3.030908857e-13, 4175), Point2D(2047, 4175), Point2D(2047, 1726.11202), Point2D(2008.768908, 1706.628072), Point2D(999.8439061, 1269.936901), Point2D(5.022926519e-13, 909.8878363)])

On LSST:

validPolygon =  Polygon([Point2D(-0.4989926346, 909.5722098), Point2D(-0.5, 4175.5), Point2D(2047.5, 4175.5), Point2D(2047.501071, 1726.209369), Point2D(2008.926333, 1706.550894), Point2D(1000.001332, 1269.859723), Point2D(-0.4989926346, 909.5722098)])

So the results are very similar and consistent with the new corner definitions.

A Jenkins build was successful.

Show

Lauren MacArthur added a comment - 04/Nov/15 4:04 PM Bob, would you mind giving this a review? As noted in the commit message, the behavior is slightly different than HSC's as the getCorners() function returns the coord of the corner of the pixels (i.e. widened by half a pixel), so instead of the lower-left-corner being (0,0) it would be (-0.5,-0.5). Similarly, a upper-right-corner of (N,M) would now be (N+0.5,M+0.5). I believe this is the desired behavior here. I ran this for ccd=22 (an edge ccd) on both stacks: On HSC: validPolygon = Polygon([Point2D(5.022926519e-13, 909.8878363), Point2D(3.030908857e-13, 4175), Point2D(2047, 4175), Point2D(2047, 1726.11202), Point2D(2008.768908, 1706.628072), Point2D(999.8439061, 1269.936901), Point2D(5.022926519e-13, 909.8878363)]) On LSST: validPolygon = Polygon([Point2D(-0.4989926346, 909.5722098), Point2D(-0.5, 4175.5), Point2D(2047.5, 4175.5), Point2D(2047.501071, 1726.209369), Point2D(2008.926333, 1706.550894), Point2D(1000.001332, 1269.859723), Point2D(-0.4989926346, 909.5722098)]) So the results are very similar and consistent with the new corner definitions. A Jenkins build was successful.

Lauren MacArthur made changes - 04/Nov/15 4:04 PM

Status	In Progress [ 3 ]	In Review [ 10004 ]
Reviewers		Bob Armstrong [ rearmstr ]

Hide

Permalink

Bob Armstrong added a comment - 13/Nov/15 11:42 AM

Only one minor format issue I put on github. Looks good.

Show

Bob Armstrong added a comment - 13/Nov/15 11:42 AM Only one minor format issue I put on github. Looks good.

Bob Armstrong made changes - 13/Nov/15 11:42 AM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Hide

Permalink

Lauren MacArthur added a comment - 16/Nov/15 1:37 PM

Thanks Bob. I fixed that format issue in addition to two other minor ones I found in the process. Rebased to master, reran Jenkins build (passed), merged to master.

Show

Lauren MacArthur added a comment - 16/Nov/15 1:37 PM Thanks Bob. I fixed that format issue in addition to two other minor ones I found in the process. Rebased to master, reran Jenkins build (passed), merged to master.

Lauren MacArthur made changes - 16/Nov/15 1:37 PM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Lauren MacArthur made changes - 16/Nov/15 4:10 PM

Remote Link