Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32649

Move psf quality statistics calculation from selectImages to computeExposureSummaryStats

    XMLWordPrintable

    Details

      Description

      Following on PREOPS-894, I noticed that the psf quality statistics (namely scatterSize, scaledScatterSize, and related ellipticity stats) that are currently only computed in PsfWcsSelectImagesTask would be more useful if they were computed in ComputeExposureSummaryStatsTask. This move would have the following advantages:
      1) We would have access to these useful quantities for all exposures, not just those that fail the test (via logging).
      2) We would have access to these useful quantities even when PsfWcsSelectImagesTask isn't configured to run.
      3) We can remove the sourceTable input from MakeWarpTask which would speed up this task when PsfWcsSelectImagesTask is configured to run.

      On this ticket I will then move these quantities (and a few others, particularly the number of psf stars used for the psf model) into the visit summary table.

      Note that originally I hoped that this could be part of the MeasurePsfTask but it needs to be computed in calibrate rather than characterize so that we have the necessary psf models and star sizes computed.

        Attachments

          Issue Links

            Activity

            Hide
            erykoff Eli Rykoff added a comment -

            Re: the backport request. This ticket goes with DM-32624 and makes the psf residual selection for coadds a lot faster and inspectable.

            Show
            erykoff Eli Rykoff added a comment - Re: the backport request. This ticket goes with DM-32624 and makes the psf residual selection for coadds a lot faster and inspectable.
            Hide
            lauren Lauren MacArthur added a comment -

            Sounds good (although I wouldn’t mind “seeing” a visitSummary table with these entries in it, I won’t block on that).

            And, in case it wasn’t obvious, I am very keen to see this ticket get approved for backporting!

            Show
            lauren Lauren MacArthur added a comment - Sounds good (although I wouldn’t mind “seeing” a visitSummary table with these entries in it, I won’t block on that). And, in case it wasn’t obvious, I am very keen to see this ticket get approved for backporting!
            Hide
            lauren Lauren MacArthur added a comment -

            Once your final Jenkins passes, you’re good to go.

            Show
            lauren Lauren MacArthur added a comment - Once your final Jenkins passes, you’re good to go.
            Hide
            yusra Yusra AlSayyad added a comment -

            backport request scheduled for a quick discussion at the CCB tomorrow re backwards compatibility.

            Show
            yusra Yusra AlSayyad added a comment - backport request scheduled for a quick discussion at the CCB tomorrow re backwards compatibility.
            Hide
            lauren Lauren MacArthur added a comment -

            Backport complete and labels updated.

            Show
            lauren Lauren MacArthur added a comment - Backport complete and labels updated.

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Lauren MacArthur
              Watchers:
              Eli Rykoff, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.